Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource metainfo to windows binaries #29

Open
stamepicmorg opened this issue Nov 21, 2024 · 0 comments
Open

Add resource metainfo to windows binaries #29

stamepicmorg opened this issue Nov 21, 2024 · 0 comments
Assignees
@stamepicmorg
Labels
Difficulty: 🟡 medium Task of medium difficulty requiring moderate effort. Engine: ⚙️ Independent Case do not refer to any Engine. OS: 🪟 Windows Case refers to Windows. Priority: ⚠️ medium Medium priority tasks that should be addressed soon. Status: 🕐 pending Issue is penging list. Type: 🚀 enhancement Improvement or addition of a new feature.

Comments

@stamepicmorg
Copy link
Contributor

For testing we could use rcedit from electron project. This tool can update metainfo in binary file: Add\edit version, icon, etc.

Some AV very sensitive if EXE or DLL do not have any metainfo.

we could in CI step update metainfo to final binaries.

example:
./rcedit-x64.exe ./hlds.exe --set-version-string ProductName "ReHLDS - Refined HLDS with fixes and new features for better performance." --set-file-version 3.13.0.788 --set-product-version 3.13.0.788 --set-version-string FileDescription "ReHLDS, Commit: 85d55d15dbc3e268df9d53db121f70c0369952e0" --set-version-string "Comments" "Commit: 85d55d15dbc3e268df9d53db121f70c0369952e0"--set-version-string CompanyName "Valve, ReHLDS Team" --set-version-string LegalCopyright "Copyright 2024 Valve, ReHLDS Team"

before
Image

after
Image

Image

some things we could get from ENVs like commit hash or version.
@stamepicmorg stamepicmorg self-assigned this Nov 21, 2024
@stamepicmorg stamepicmorg converted this from a draft issue Nov 21, 2024
@stamepicmorg stamepicmorg mentioned this issue Nov 21, 2024
Open
@stamepicmorg stamepicmorg changed the title Add resource metainfo to windows binaryes Add resource metainfo to windows binaries Nov 21, 2024
@stamepicmorg stamepicmorg added Difficulty: 🟡 medium Task of medium difficulty requiring moderate effort. Priority: ⚠️ medium Medium priority tasks that should be addressed soon. Type: 🚀 enhancement Improvement or addition of a new feature. Status: 🕐 pending Issue is penging list. Engine: ⚙️ Independent Case do not refer to any Engine. OS: 🪟 Windows Case refers to Windows. labels Nov 21, 2024
stamepicmorg added a commit to rehlds/ReHLDS that referenced this issue Dec 15, 2024
@stamepicmorg
Added codesign and resources
30a639b 
- for Windows: rehlds/.github#30 and rehlds/.github#29

- for Linux:  rehlds/.github#28
@stamepicmorg stamepicmorg mentioned this issue Dec 15, 2024
Merged
3 tasks
SergeyShorokhov pushed a commit to rehlds/ReHLDS that referenced this issue Dec 26, 2024
@stamepicmorg
Added codesign and resources (#1069)
e999171 
* Added codesign and resources

- for Windows: rehlds/.github#30 and rehlds/.github#29

- for Linux:  rehlds/.github#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stamepicmorg stamepicmorg

Labels
Difficulty: 🟡 medium Task of medium difficulty requiring moderate effort. Engine: ⚙️ Independent Case do not refer to any Engine. OS: 🪟 Windows Case refers to Windows. Priority: ⚠️ medium Medium priority tasks that should be addressed soon. Status: 🕐 pending Issue is penging list. Type: 🚀 enhancement Improvement or addition of a new feature.
Projects
🤝 Community & UX Initiatives
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stamepicmorg