-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a GithubReleases
version provider
#2837
Conversation
How do we manage the issue of running out of api requests? We are going to very quickly exhaust our token with this. That's why we use the atom feed in the first place. |
That's a public endpoint afaik. There's no API, just a HTTP redirect. See https://docs.github.com/en/repositories/releasing-projects-on-github/linking-to-releases#linking-to-the-latest-release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question on tokens. Also, if in testing we exhaust the bot token, this will cause the bot to fail since it won't be able to open prs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
+ Coverage 75.10% 75.14% +0.03%
==========================================
Files 111 111
Lines 11240 11270 +30
==========================================
+ Hits 8442 8469 +27
- Misses 2798 2801 +3 ☔ View full report in Codecov by Sentry. |
Comes from an Element conversation. Maintainers publish tags, and then the GH release. They only want the GH releases caught by the bot. The
releases.atom
feed sadly lists tags along with the releases. This alternative method guarantees only releases are caught by leveraging the/releases/latest
endpoint.I think I need to update the pydantic model for the
version_sources
enum, but I can't find it.