Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Prerelease on GitHub #324

Open
jakirkham opened this issue Aug 17, 2018 · 8 comments
Open

Check for Prerelease on GitHub #324

jakirkham opened this issue Aug 17, 2018 · 8 comments

Comments

@jakirkham
Copy link
Contributor

It's possible to mark a release as a Prerelease on GitHub. Doing this is independent of noting RC in the version or similar. This is something that conda does regularly and some other packages do as well. Would be nice if the bot could check for the Prerelease indicator and handle it the same way as we do other RCs.

ref: conda-forge/tmux-feedstock#10 (comment)

@CJ-Wright
Copy link
Member

This might be a bit difficult since most of the time RawURL triggers before GitHub so we won't have access to the full github json.

@ihnorton
Copy link
Contributor

The github releases.atom feed doesn't distinguish draft releases, unfortunately. AFAICT the bot is currently using RSS...

It looks like there are already a lot of issues with rate-limiting, so it might be problematic to use the GitHub API directly? Perhaps continue using RSS for routine checks, but then filter for pre-release status using the GH API when a potential new release is detected.

@ytausch
Copy link
Contributor

ytausch commented Jul 29, 2024

Using the new GithubReleases version provider exclusively is a good workaround (fix?) for this since the /releases/latest endpoint of GitHub ignores prereleases.

Try it out: https://github.com/microsoft/terminal/releases/latest

I will add documentation to the conda-forge wiki about this. After that, I think this issue can be closed.

@ytausch
Copy link
Contributor

ytausch commented Jul 29, 2024

Documentation is here: conda-forge/conda-smithy#1998

Exemplary usage: conda-forge/windows-terminal-feedstock#5

@mfisher87
Copy link

@ytausch
Copy link
Contributor

ytausch commented Aug 13, 2024

@mfisher87 I highly suspect this was just some flaky behavior of the bot because the old pre-release version was still cached in the bot's metadata.

1.6.4, which is also a pre-release, was skipped by the bot correctly.

If the issue comes up again, feel free to just reply in this issue.

@ytausch
Copy link
Contributor

ytausch commented Aug 13, 2024

Quarto 1.5.56 should be PRed by the bot after this metadata patch is merged - this is a bug on the bot's side.

@mfisher87
Copy link

Amazing, thank you @ytausch 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants