-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for Prerelease on GitHub #324
Comments
This might be a bit difficult since most of the time |
The github It looks like there are already a lot of issues with rate-limiting, so it might be problematic to use the GitHub API directly? Perhaps continue using RSS for routine checks, but then filter for pre-release status using the GH API when a potential new release is detected. |
Using the new GithubReleases version provider exclusively is a good workaround (fix?) for this since the Try it out: https://github.com/microsoft/terminal/releases/latest I will add documentation to the conda-forge wiki about this. After that, I think this issue can be closed. |
Documentation is here: conda-forge/conda-smithy#1998 Exemplary usage: conda-forge/windows-terminal-feedstock#5 |
@ytausch I attempted this, but I still got a PR from a pre-release. Should I open a new issue, or should it be tracked by this one? conda-forge/quarto-feedstock#54 |
@mfisher87 I highly suspect this was just some flaky behavior of the bot because the old pre-release version was still cached in the bot's metadata.
If the issue comes up again, feel free to just reply in this issue. |
Quarto 1.5.56 should be PRed by the bot after this metadata patch is merged - this is a bug on the bot's side. |
Amazing, thank you @ytausch 😍 |
It's possible to mark a release as a Prerelease on GitHub. Doing this is independent of noting RC in the version or similar. This is something that
conda
does regularly and some other packages do as well. Would be nice if the bot could check for the Prerelease indicator and handle it the same way as we do other RCs.ref: conda-forge/tmux-feedstock#10 (comment)
The text was updated successfully, but these errors were encountered: