-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wasm cross compilation #658
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
787f65f
Add wasm cross compilation
dfordivam f1fa8c9
Merge branch 'develop' into wasm-support-1
3noch b1b6275
Add wasm-cross thunk, and use it for jsaddle-wasm.
dfordivam 324a695
Bump reflex-dom, with the wasm changes
dfordivam bf23e45
minor code cleanup
dfordivam 540b8e9
Merge branch 'wasm-support-1' of github.com:dfordivam/reflex-platform…
dfordivam d3ddf20
Delete unused file
dfordivam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{ | ||
"owner": "reflex-frp", | ||
"repo": "reflex-dom", | ||
"branch": "master", | ||
"rev": "94c26076a71f229b5bd27128cf6fc0dbcba011ac", | ||
"sha256": "00sx5x51jv1j24qlhrbp5sqnqcyz1iy2sgjap0y97c4dkzxi3wd3" | ||
"branch": "develop", | ||
"rev": "e2b846037badee035d0c466173badd1c4c474d5a", | ||
"sha256": "12vj25zzg2xr6mvyw83skr24y30swmg79kmg7lizy3klwpv5dysc" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
self: super: { | ||
jsaddle-warp = null; | ||
jsaddle-webkitgtk = null; | ||
jsaddle-webkit2gtk = null; | ||
jsaddle-wkwebview = null; | ||
mkDerivation = args: super.mkDerivation (args // { | ||
dontStrip = true; | ||
enableSharedExecutables = false; | ||
enableSharedLibraries = false; | ||
enableDeadCodeElimination = false; | ||
doHaddock = false; | ||
doCheck = false; | ||
enableLibraryProfiling = false; | ||
}); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{ | ||
"owner": "nixos", | ||
"owner": "WebGHC", | ||
"repo": "nixpkgs", | ||
"branch": "release-19.09", | ||
"rev": "49550f29cd9d6ed27f4a76ba3c3fe30edf882eb7", | ||
"sha256": "003fpkrcc5mw33q670q4z865zpr430cllbxhyzj8k9p4hbc8yqda" | ||
"branch": "wasm-r-p-1909-integ", | ||
"rev": "423fa4adb6276298cde0c12205efeb7bf1cbe805", | ||
"sha256": "0ssvc5j0p7nip0qsrdbfgc6wihzwyxa23hbr80dmjbfizywz7nzg" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# DO NOT HAND-EDIT THIS FILE | ||
let fetch = { private ? false, fetchSubmodules ? false, owner, repo, rev, sha256, ... }: | ||
if !fetchSubmodules && !private then builtins.fetchTarball { | ||
url = "https://github.com/${owner}/${repo}/archive/${rev}.tar.gz"; inherit sha256; | ||
} else (import <nixpkgs> {}).fetchFromGitHub { | ||
inherit owner repo rev sha256 fetchSubmodules private; | ||
}; | ||
in import (fetch (builtins.fromJSON (builtins.readFile ./github.json))) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"owner": "WebGHC", | ||
"repo": "wasm-cross", | ||
"branch": "reflex-platform-integ", | ||
"private": false, | ||
"rev": "98dbc945147ed646724682a2a4f470bc592a5501", | ||
"sha256": "1vnxmxx262h6r0lslidd0fnnrsjz88jfx1dj7v66vl0pjdz7icb4" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this? can this get merged to a main branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes like (
lib/systems/doubles.nix
) which cannot be put in upstream, neither can they be done via overlay, so we will have to use a fork.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
lib/systems/doubles.nix
change looks good to upstream to me. Did someone say otherwise?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get a PR up make a ticket to check back on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ericson2314 yes, now I realized that it should be possible to upstream that, even though the cross-compilation to wasm will still happen by overlays.