Add wasm cross compilation #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3noch
reviewed
Apr 29, 2020
3noch
reviewed
Apr 29, 2020
3noch
reviewed
Apr 29, 2020
| "branch": "release-19.09", | ||
| "rev": "49550f29cd9d6ed27f4a76ba3c3fe30edf882eb7", | ||
| "sha256": "003fpkrcc5mw33q670q4z865zpr430cllbxhyzj8k9p4hbc8yqda" | ||
| "branch": "wasm-r-p-1909-integ", |
There was a problem hiding this comment.
what's this? can this get merged to a main branch?
There was a problem hiding this comment.
There are some changes like (lib/systems/doubles.nix) which cannot be put in upstream, neither can they be done via overlay, so we will have to use a fork.
There was a problem hiding this comment.
The lib/systems/doubles.nix change looks good to upstream to me. Did someone say otherwise?
There was a problem hiding this comment.
Let's get a PR up make a ticket to check back on it.
There was a problem hiding this comment.
@Ericson2314 yes, now I realized that it should be possible to upstream that, even though the cross-compilation to wasm will still happen by overlays.
3noch
reviewed
Apr 29, 2020
Export of wasmCross is needed for obelisk
… into wasm-support-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.