This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add navigator as a built-in widget #323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
keiya01
force-pushed
the
feature/navigator-builtin-widget
branch
from
September 26, 2022 00:51
b84d344
to
73d0389
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 17.83% 18.15% +0.32%
==========================================
Files 508 510 +2
Lines 49870 50289 +419
Branches 582 613 +31
==========================================
+ Hits 8893 9129 +236
- Misses 40957 41140 +183
Partials 20 20
|
KaWaite
reviewed
Sep 27, 2022
KaWaite
reviewed
Sep 27, 2022
KaWaite
reviewed
Sep 27, 2022
rot1024
changed the title
feat: add navigator as builtin widget
feat: add navigator as a builtin widget
Sep 27, 2022
rot1024
changed the title
feat: add navigator as a builtin widget
feat: add navigator as a built-in widget
Sep 27, 2022
rot1024
suggested changes
Sep 27, 2022
Co-authored-by: rot1024 <[email protected]>
keiya01
force-pushed
the
feature/navigator-builtin-widget
branch
from
September 27, 2022 12:22
2df8796
to
f720e01
Compare
keiya01
force-pushed
the
feature/navigator-builtin-widget
branch
from
September 27, 2022 12:39
ee83286
to
5877026
Compare
rot1024
approved these changes
Sep 29, 2022
KaWaite
approved these changes
Oct 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I added Navigator as builtin widget.
What I've done
rotateRight
as reearth API. This is used to handle rotate globeorbit
as reearth API. This is used to rotate globe like orbit.zoomIn
andzoomOut
API.What I haven't done
How I tested
Screenshot
Rotating the globe
https://user-images.githubusercontent.com/34934510/192100500-b7a18e19-75f1-4e18-8e6f-7d708506cf2c.mp4
Zooming the globe
https://user-images.githubusercontent.com/34934510/192100510-4e566d53-2f3e-4ea5-9ddb-1bf839e0795a.mp4
Which point I want you to review particularly
Memo
Manifest is here reearth/reearth-visualizer#342