Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: add navigator as a built-in widget #323

Merged
merged 12 commits into from
Oct 3, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Sep 24, 2022

Overview

I added Navigator as builtin widget.

What I've done

  • Added rotateRight as reearth API. This is used to handle rotate globe
  • Added orbit as reearth API. This is used to rotate globe like orbit.
  • Added zooming animation to existing zoomIn and zoomOut API.
  • Added Navigator component as builtin widget

What I haven't done

How I tested

  1. Set Navigator builtin widget
  2. Check if the Navigator works like the following screenshot.

Screenshot

Rotating the globe
https://user-images.githubusercontent.com/34934510/192100500-b7a18e19-75f1-4e18-8e6f-7d708506cf2c.mp4

Zooming the globe
https://user-images.githubusercontent.com/34934510/192100510-4e566d53-2f3e-4ea5-9ddb-1bf839e0795a.mp4

Which point I want you to review particularly

Memo

Manifest is here reearth/reearth-visualizer#342

@keiya01 keiya01 self-assigned this Sep 24, 2022
@netlify
Copy link

netlify bot commented Sep 24, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit cf7ba79
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/633adee9881801000861c3df
😎 Deploy Preview https://deploy-preview-323--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@keiya01 keiya01 force-pushed the feature/navigator-builtin-widget branch from b84d344 to 73d0389 Compare September 26, 2022 00:51
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #323 (62e9cd5) into main (09e4785) will increase coverage by 0.32%.
The diff coverage is 58.44%.

❗ Current head 62e9cd5 differs from pull request most recent head cf7ba79. Consider uploading reports for the commit cf7ba79 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   17.83%   18.15%   +0.32%     
==========================================
  Files         508      510       +2     
  Lines       49870    50289     +419     
  Branches      582      613      +31     
==========================================
+ Hits         8893     9129     +236     
- Misses      40957    41140     +183     
  Partials       20       20              
Impacted Files Coverage Δ
src/components/molecules/Visualizer/Engine/ref.ts 0.00% <0.00%> (ø)
src/components/molecules/Visualizer/Plugin/api.ts 6.08% <0.00%> (-0.15%) ⬇️
...rc/components/molecules/Visualizer/Plugin/types.ts 0.00% <0.00%> (ø)
...lizer/Widget/Navigator/NavigatorPresenter/types.ts 0.00% <ø> (ø)
.../Widget/Navigator/NavigatorPresenter/utils.test.ts 100.00% <ø> (ø)
...nts/molecules/Visualizer/Widget/Navigator/hooks.ts 0.00% <0.00%> (ø)
...ts/molecules/Visualizer/Widget/Navigator/index.tsx 0.00% <0.00%> (ø)
.../components/molecules/Visualizer/Widget/builtin.ts 0.00% <0.00%> (ø)
src/components/molecules/Visualizer/hooks.ts 0.00% <0.00%> (ø)
src/components/molecules/Visualizer/index.tsx 0.00% <0.00%> (ø)
... and 12 more

@rot1024 rot1024 changed the title feat: add navigator as builtin widget feat: add navigator as a builtin widget Sep 27, 2022
@rot1024 rot1024 changed the title feat: add navigator as a builtin widget feat: add navigator as a built-in widget Sep 27, 2022
@keiya01 keiya01 force-pushed the feature/navigator-builtin-widget branch from 2df8796 to f720e01 Compare September 27, 2022 12:22
@keiya01 keiya01 force-pushed the feature/navigator-builtin-widget branch from ee83286 to 5877026 Compare September 27, 2022 12:39
@keiya01 keiya01 enabled auto-merge (squash) October 3, 2022 13:09
@keiya01 keiya01 merged commit 3befd4c into main Oct 3, 2022
@keiya01 keiya01 deleted the feature/navigator-builtin-widget branch October 3, 2022 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants