Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add builtint navigator widget manifest #342

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Sep 24, 2022

Overview

What I've done

  • Added manifest for navigator builtin widget

What I haven't done

How I tested

see reearth/reearth-web#323

Which point I want you to review particularly

Memo

@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Merging #342 (33186ea) into main (6949bee) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 33186ea differs from pull request most recent head 412f66a. Consider uploading reports for the commit 412f66a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   35.71%   35.72%           
=======================================
  Files         339      339           
  Lines       30254    30248    -6     
=======================================
  Hits        10805    10805           
+ Misses      18399    18393    -6     
  Partials     1050     1050           
Impacted Files Coverage Δ
server/internal/app/main.go 0.00% <0.00%> (ø)

@keiya01 keiya01 requested a review from rot1024 October 3, 2022 13:08
@rot1024 rot1024 force-pushed the feat/add-builtin-navigator-widget branch from 33186ea to 8449873 Compare October 4, 2022 02:04
@rot1024 rot1024 changed the title feat: add builtint navigator widget manifest feat(server): add builtint navigator widget manifest Oct 4, 2022
@keiya01 keiya01 enabled auto-merge (squash) October 4, 2022 12:23
@keiya01 keiya01 merged commit f6834f8 into main Oct 4, 2022
@keiya01 keiya01 deleted the feat/add-builtin-navigator-widget branch October 4, 2022 12:26
pyshx pushed a commit that referenced this pull request Apr 17, 2023
* feat: add plugin api viewport

* refactor: make viewport always avaliable

* refactor: add type VisualizerViewport

* refactor: pass viewport to infobox

* refactor: visualizerViewport nullable

* refactor: update type definition

* refactor: move viewportMobileMaxWidth out of hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants