Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix title padding changes updating page padding #840

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Nov 29, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@KaWaite KaWaite self-assigned this Nov 29, 2023
Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 1c85510
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6566ec37c503a30008cd780e
😎 Deploy Preview https://deploy-preview-840--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #840 (1c85510) into main (1ff1f7d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   25.63%   25.63%   -0.01%     
==========================================
  Files        1641     1641              
  Lines      180579   180588       +9     
  Branches     3917     3917              
==========================================
- Hits        46291    46289       -2     
- Misses     133199   133210      +11     
  Partials     1089     1089              
Flag Coverage Δ
web 23.84% <0.00%> (-0.01%) ⬇️
web-beta 23.84% <0.00%> (-0.01%) ⬇️
web-classic 23.84% <0.00%> (-0.01%) ⬇️
web-utils 23.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ryPanel/Block/builtin/common/ActionPanel/index.tsx 0.00% <0.00%> (ø)
...src/beta/lib/core/StoryPanel/ActionPanel/index.tsx 0.00% <0.00%> (ø)
.../lib/core/StoryPanel/Block/builtin/Title/index.tsx 0.00% <0.00%> (ø)
...b/core/StoryPanel/Block/builtin/common/Wrapper.tsx 0.00% <0.00%> (ø)
.../beta/lib/core/StoryPanel/SelectableArea/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Page/hooks.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@github-actions github-actions bot removed the server label Nov 29, 2023
@KaWaite KaWaite merged commit 42d9ed0 into main Nov 29, 2023
16 checks passed
@KaWaite KaWaite deleted the fix-title-padding-bug branch November 29, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant