Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(web): handle cesium private property of shadow map #531

Merged
merged 2 commits into from
Jun 29, 2023
Merged

refactor(web): handle cesium private property of shadow map #531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5539b70
refactor: handle private property
airslice Jun 28, 2023
5a41279
Merge branch 'main' into refactor/visualizer-shadow-map-private-property
airslice Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 33 additions & 12 deletions web/src/beta/lib/core/engines/Cesium/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,20 +134,20 @@ export default ({

// shadow map
type ShadowMapBias = {
polygonOffsetFactor: number;
polygonOffsetUnits: number;
normalOffsetScale: number;
normalShading: boolean;
normalShadingSmooth: number;
depthBias: number;
polygonOffsetFactor?: number;
polygonOffsetUnits?: number;
normalOffsetScale?: number;
normalShading?: boolean;
normalShadingSmooth?: number;
depthBias?: number;
};

useEffect(() => {
const shadowMap = cesium?.current?.cesiumElement?.shadowMap as
| (ShadowMap & {
_terrainBias: ShadowMapBias;
_pointBias: ShadowMapBias;
_primitiveBias: ShadowMapBias;
_terrainBias?: ShadowMapBias;
_pointBias?: ShadowMapBias;
_primitiveBias?: ShadowMapBias;
})
| undefined;
if (!shadowMap) return;
Expand Down Expand Up @@ -183,9 +183,30 @@ export default ({
normalShadingSmooth: 0.1,
depthBias: 0.0005,
};
Object.assign(shadowMap._terrainBias, defaultTerrainBias);
Object.assign(shadowMap._primitiveBias, defaultPrimitiveBias);
Object.assign(shadowMap._pointBias, defaultPointBias);

if (!shadowMap._terrainBias) {
if (import.meta.env.DEV) {
throw new Error("`shadowMap._terrainBias` could not found");
}
} else {
Object.assign(shadowMap._terrainBias, defaultTerrainBias);
}

if (!shadowMap._primitiveBias) {
if (import.meta.env.DEV) {
throw new Error("`shadowMap._primitiveBias` could not found");
}
} else {
Object.assign(shadowMap._primitiveBias, defaultPrimitiveBias);
}

if (!shadowMap._pointBias) {
if (import.meta.env.DEV) {
throw new Error("`shadowMap._pointBias` could not found");
}
} else {
Object.assign(shadowMap._pointBias, defaultPointBias);
}
}, [
property?.atmosphere?.softShadow,
property?.atmosphere?.shadowDarkness,
Expand Down