Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): handle cesium private property of shadow map #531

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

airslice
Copy link
Contributor

Overview

  • Handle private property of cesium shadowMap as optional property.
  • Throw an error if these private property is undefined.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 5a41279
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/649d2c2c82c69500083f1dec

@github-actions github-actions bot added the web label Jun 28, 2023
@airslice airslice marked this pull request as ready for review June 28, 2023 10:41
@airslice airslice requested a review from keiya01 as a code owner June 28, 2023 10:41
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #531 (5a41279) into main (de536e8) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   26.65%   26.67%   +0.01%     
==========================================
  Files        1342     1342              
  Lines      144699   144512     -187     
  Branches     3485     3485              
==========================================
- Hits        38571    38545      -26     
+ Misses     105005   104845     -160     
+ Partials     1123     1122       -1     
Flag Coverage Δ
web 23.98% <0.00%> (-0.01%) ⬇️
web-beta 23.98% <0.00%> (-0.01%) ⬇️
web-classic 23.98% <0.00%> (-0.01%) ⬇️
web-utils 23.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/lib/core/engines/Cesium/hooks.ts 0.00% <0.00%> (ø)

... and 50 files with indirect coverage changes

@airslice airslice requested review from isoppp and pyshx and removed request for isoppp June 29, 2023 07:16
Copy link
Contributor

@pyshx pyshx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@airslice airslice merged commit ae4cdd6 into main Jun 29, 2023
@airslice airslice deleted the refactor/visualizer-shadow-map-private-property branch June 29, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants