Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): serve published pages on root path #386

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Feb 14, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #386 (7c4a2c9) into main (9c8714b) will increase coverage by 0.14%.
The diff coverage is 70.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   35.89%   36.04%   +0.14%     
==========================================
  Files         346      346              
  Lines       30739    30785      +46     
==========================================
+ Hits        11035    11096      +61     
+ Misses      18625    18607      -18     
- Partials     1079     1082       +3     
Impacted Files Coverage Δ
server/internal/app/app.go 0.00% <0.00%> (ø)
server/internal/app/config.go 49.08% <ø> (ø)
server/internal/usecase/interactor/published.go 17.72% <0.00%> (-1.20%) ⬇️
server/internal/app/web.go 85.00% <78.94%> (+85.00%) ⬆️
server/internal/app/public.go 42.37% <88.46%> (+9.71%) ⬆️

@rot1024 rot1024 merged commit 8455319 into main Feb 14, 2023
@rot1024 rot1024 deleted the deliver-published branch February 14, 2023 12:39
pyshx pushed a commit that referenced this pull request Apr 17, 2023
* chore: remove legacy prefix for Resource component

* feat: support CZML

* feat: add extractSimpleLayerData util

* Update src/core/engines/Cesium/Feature/Resource/index.stories.tsx

Co-authored-by: rot1024 <[email protected]>

* feat: support glTF on reearth/core (#386)

* feat: support gltf

* fix: add url in model appearance

Co-authored-by: rot1024 <[email protected]>
pyshx pushed a commit that referenced this pull request Apr 17, 2023
* chore: remove legacy prefix for Resource component

* feat: support CZML

* feat: add extractSimpleLayerData util

* Update src/core/engines/Cesium/Feature/Resource/index.stories.tsx

Co-authored-by: rot1024 <[email protected]>

* feat: support raster appearance and wms

* chore: rename

* fix: data type

* test: fix storybook data

* fix: remove zindex

* fix: restrict pickProperty

* feat: support glTF on reearth/core (#386)

* feat: support gltf

* fix: add url in model appearance

Co-authored-by: rot1024 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant