Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): make widget area gap optional #383

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

mimoham24
Copy link
Contributor

Overview

regarding the padding default value I did the following changes:

  • padding object is nil if not set
  • gap is declared as a pointer

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #383 (f52b3f0) into main (a019c54) will not change coverage.
The diff coverage is 77.77%.

❗ Current head f52b3f0 differs from pull request most recent head 286dbd1. Consider uploading reports for the commit 286dbd1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   35.58%   35.58%           
=======================================
  Files         346      346           
  Lines       30695    30695           
=======================================
  Hits        10922    10922           
  Misses      18716    18716           
  Partials     1057     1057           
Impacted Files Coverage Δ
...ternal/adapter/gql/gqlmodel/convert_scene_align.go 9.73% <0.00%> (ø)
...ernal/infrastructure/mongo/mongodoc/scene_align.go 0.00% <ø> (ø)
server/internal/usecase/interactor/scene.go 0.00% <0.00%> (ø)
server/pkg/scene/builder/encoder.go 97.46% <ø> (ø)
server/pkg/scene/widget_area.go 92.72% <100.00%> (ø)
server/pkg/scene/widget_section.go 92.72% <100.00%> (ø)

@rot1024 rot1024 enabled auto-merge (squash) February 8, 2023 03:19
@rot1024 rot1024 disabled auto-merge February 8, 2023 03:19
@rot1024 rot1024 changed the title fix(server): convert gap to pointer fix(server): make widget area gap optional Feb 8, 2023
@rot1024 rot1024 enabled auto-merge (squash) February 8, 2023 03:19
@rot1024 rot1024 merged commit 1e00ca7 into main Feb 8, 2023
@rot1024 rot1024 deleted the was/padding/default-value-refactoring branch February 8, 2023 03:23
pyshx pushed a commit that referenced this pull request Apr 17, 2023
* chore: remove legacy prefix for Resource component

* feat: support CZML

* feat: add extractSimpleLayerData util

* Update src/core/engines/Cesium/Feature/Resource/index.stories.tsx

Co-authored-by: rot1024 <[email protected]>

* feat: support glTF on reearth/core (#386)

* feat: support gltf

* fix: add url in model appearance

Co-authored-by: rot1024 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants