Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixi(prisma): Set default cwd for runCommand task to base #4604

Merged
merged 3 commits into from
Mar 1, 2022

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Mar 1, 2022

The runCommandTask which currently is only used in https://github.com/redwoodjs/redwood/blob/main/packages/cli/src/lib/generatePrismaClient.js had the cwd set to the api side.

This PR does the following:

  1. Run command tasks now take a cwd
  2. Sets default cwd to the root of the project

This won't 100% solve the problem we're seeing with prisma, as it seems to be a problem on their side too. Tracking issue here: #4605

@dac09 dac09 merged commit 6c5c823 into redwoodjs:main Mar 1, 2022
@dac09 dac09 deleted the fix/prisma-generate-cwd branch March 1, 2022 15:54
@jtoar jtoar added this to the next-release milestone Mar 1, 2022
thedavidprice pushed a commit that referenced this pull request Mar 1, 2022
dac09 added a commit that referenced this pull request Mar 2, 2022
…ors-db-auth

* 'main' of github.com:redwoodjs/redwood: (366 commits)
  fixi(prisma): Set default cwd for runCommand task to base (#4604)
  Tailwind: Generate prettier-approved code (#4541)
  Webhook verifiers: Add Base64Sha256 version for Svix webhooks used by Clerk auth (#4598)
  Update dependency cypress to v9.5.1 (#4602)
  Update dependency typescript to v4.6.2 (#4603)
  Update dependency yargs-parser to v21.0.1 (#4595)
  Update typescript-eslint monorepo to v5.13.0 (#4601)
  fix dbAuth Auth template roles logic and types, run type-check on Smoke-test CI, and resolve TS errors (#4566)
  Update seed.ts to reflect correct input type (#4560)
  feat(exec): Allow listing of scripts with rw exec to improve dx (#4600)
  Update dependency zx to v5.2.0 (#4596)
  remove packageManager yarn v3 from fixture
  Update dependency @types/lodash to v4.14.179 (#4582)
  Bump url-parse in /__fixtures__/example-todo-main-with-errors (#4584)
  Bump url-parse from 1.5.7 to 1.5.10 in /__fixtures__/example-todo-main (#4585)
  Update dependency @supabase/supabase-js to v1.30.7 (#4589)
  Checking jest config web api (#4529)
  Add Codemod to Update Fatal Error Page to support Development version (#4577)
  Update dependency eslint-plugin-react to v7.29.2 (#4586)
  Update dependency systeminformation to v5.11.5 (#4587)
  ...
dac09 added a commit that referenced this pull request Mar 3, 2022
…rojects-to-yarn-3

* 'main' of github.com:redwoodjs/redwood: (29 commits)
  Update dependency eslint-config-prettier to v8.5.0 (#4631)
  Update dependency msw to v0.38.2 (#4630)
  Update dependency @clerk/types to v1.27.0 (#4628)
  Update dependency @clerk/clerk-js to v2.16.0 (#4627)
  Update dependency @types/react-dom to v17.0.13 (#4629)
  Update dependency @types/testing-library__jest-dom to v5.14.3 (#4624)
  Update dependency @types/aws-lambda to v8.10.93 (#4620)
  Webhook verifiers: Make them all support timestamp diff check (#4608)
  Add custom log payload support to logFormatter (#4619)
  Update dependency @types/react-dom to v17.0.12 (#4621)
  part II of #4623 (#4626)
  Update dependency systeminformation to v5.11.6 (#4611)
  Update dependency @clerk/clerk-js to v2.15.0 (#4606)
  remove Redwood extension from vscode rec (#4613)
  (fixture chore) pin fixture autoprefixer 9.8.8 (#4623)
  update yarn.lock
  v0.47.1
  update yarn.lock
  fixi(prisma): Set default cwd for runCommand task to base (#4604)
  Update actions/checkout action to v3 (#4610)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

4 participants