Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Codemod to Update Fatal Error Page to support Development version #4577

Merged
merged 6 commits into from
Feb 26, 2022
Merged

Add Codemod to Update Fatal Error Page to support Development version #4577

merged 6 commits into from
Feb 26, 2022

Conversation

dthyresson
Copy link
Contributor

This PR is for a v0.47 coded that updates the web side's FatalErrorPage.

The codemod will:

  • fetch the latest FatalErrorPage from the create redwood app template
  • replace (and overwrite) the file in your RW app
  • handle js or tsx

Note: This is a DRAFT.

Earlier, my test failed, but now, they seem to pass:

 PASS  src/codemods/v47.x/updateDevFatalErrorPage/__tests__/updateDevFatalErrorPage.test.ts
  updateDevFatalErrorPage
    ✓ Replaces the FatalErrorPage with a new version that includes development info (119 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        0.784 s, estimated 2 s
Ran all test suites matching /updateDevFatalErrorPage/i.

@dthyresson dthyresson requested review from jtoar and dac09 February 25, 2022 03:09
@dthyresson dthyresson added the release:chore This PR is a chore (means nothing for users) label Feb 25, 2022
@jtoar jtoar enabled auto-merge (squash) February 26, 2022 09:27
@jtoar jtoar merged commit 23bf323 into redwoodjs:main Feb 26, 2022
@jtoar jtoar added this to the next-release milestone Feb 26, 2022
@dthyresson dthyresson mentioned this pull request Feb 26, 2022
Closed
@dthyresson dthyresson linked an issue Feb 26, 2022 that may be closed by this pull request
Code mods for new DevFatalErrorPage #4545
Closed
dac09 added a commit that referenced this pull request Mar 2, 2022
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into feat/dc-rc-c…
aff7172 
…ors-db-auth

* 'main' of github.com:redwoodjs/redwood: (366 commits)
  fixi(prisma): Set default cwd for runCommand task to base (#4604)
  Tailwind: Generate prettier-approved code (#4541)
  Webhook verifiers: Add Base64Sha256 version for Svix webhooks used by Clerk auth (#4598)
  Update dependency cypress to v9.5.1 (#4602)
  Update dependency typescript to v4.6.2 (#4603)
  Update dependency yargs-parser to v21.0.1 (#4595)
  Update typescript-eslint monorepo to v5.13.0 (#4601)
  fix dbAuth Auth template roles logic and types, run type-check on Smoke-test CI, and resolve TS errors (#4566)
  Update seed.ts to reflect correct input type (#4560)
  feat(exec): Allow listing of scripts with rw exec to improve dx (#4600)
  Update dependency zx to v5.2.0 (#4596)
  remove packageManager yarn v3 from fixture
  Update dependency @types/lodash to v4.14.179 (#4582)
  Bump url-parse in /__fixtures__/example-todo-main-with-errors (#4584)
  Bump url-parse from 1.5.7 to 1.5.10 in /__fixtures__/example-todo-main (#4585)
  Update dependency @supabase/supabase-js to v1.30.7 (#4589)
  Checking jest config web api (#4529)
  Add Codemod to Update Fatal Error Page to support Development version (#4577)
  Update dependency eslint-plugin-react to v7.29.2 (#4586)
  Update dependency systeminformation to v5.11.5 (#4587)
  ...
@thedavidprice thedavidprice modified the milestones: next-release, v0.48.0 Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtoar jtoar jtoar approved these changes

@dac09 dac09 Awaiting requested review from dac09

Assignees

@dthyresson dthyresson

Labels
release:chore This PR is a chore (means nothing for users)
Projects
No open projects
Release
Status: Archived
Milestone
v0.48.0
Development

Successfully merging this pull request may close these issues.

Code mods for new DevFatalErrorPage
3 participants
@dthyresson @jtoar @thedavidprice