Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build:test-project to CI along with additional commands #3914

Closed
wants to merge 2 commits into from

Conversation

thedavidprice
Copy link
Contributor

@thedavidprice thedavidprice commented Dec 16, 2021

The idea here is to round out my release QA process in CI:

  • build and test the build:test-project with every PR
  • use the build project to test CLI commands not yet included in CI

ToDo:

  • Matrix run on Linux and Windows; Node.js v14 and v16
  • include all commands from E2E + QA commands
  • Possibly use Playwright to manage yarn rw dev and yarn rw serve
  • add necesary options to yarn build:test-project

@thedavidprice thedavidprice self-assigned this Dec 16, 2021
@thedavidprice thedavidprice marked this pull request as draft December 16, 2021 18:37
@jtoar
Copy link
Contributor

jtoar commented Dec 16, 2021

@thedavidprice If yarn build:test-project was failing for you, there's a fix for it in my PR here: d9a0c70.

@dac09
Copy link
Contributor

dac09 commented Dec 16, 2021

@thedavidprice once you do this, maybe we can simply the test project creation so that we just copy files across rather than use jscodeshift or run generate commands?

@thedavidprice
Copy link
Contributor Author

@dac09 OH, this just gave me an idea... will work on it within this PR and show you that way.

🤞

@thedavidprice
Copy link
Contributor Author

replaced by #4495

@thedavidprice thedavidprice deleted the dsp-test-project-e2e branch February 16, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants