Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __fixtures__ (maybe?) #3750

Open
thedavidprice opened this issue Nov 19, 2021 · 2 comments
Open

Update __fixtures__ (maybe?) #3750

thedavidprice opened this issue Nov 19, 2021 · 2 comments

Comments

@thedavidprice
Copy link
Contributor

@dac09 @peterp
Admittedly, I don't pay a lot of attention to the two __fixtures__ directories in the monorepo. But when I looked through them today, I noticed they're not up to date with latest features/syntax.

I'm guessing it's not ideal, but is it ok? (For now?)

PP, I know there's a pending project to re-write/structure testing, which would include fixtures. My questions here are mostly concerned with whether or not we could be relying on faulty tests between now and then. Again, I'm assuming we're ok and have been updating the parts we are using for tests. (Right? 😬)

@thedavidprice
Copy link
Contributor Author

@jtoar I have an intermediate step here. This would be a part of a testing overhaul, that won't come until after v1. But in the meantime I have an idea to try along with needing to consolidate the open Issues related to overhauling testing and CI.

@thedavidprice thedavidprice self-assigned this Jan 24, 2022
@thedavidprice thedavidprice moved this from Needs discussion to Todo in Triage Jan 24, 2022
@jtoar jtoar moved this from Todo to Needs discussion in Triage Jan 25, 2022
@jtoar jtoar removed this from Triage Feb 1, 2022
@jtoar jtoar moved this to In progress in Release Feb 1, 2022
@jtoar jtoar added this to Release Feb 1, 2022
@jtoar
Copy link
Contributor

jtoar commented Feb 1, 2022

The first step will happen in #3914.

@jtoar jtoar moved this from In progress to Todo in Release Feb 1, 2022
@jtoar jtoar removed this from Release Feb 15, 2022
@jtoar jtoar added this to Main May 5, 2022
@jtoar jtoar moved this to Backlog in Main May 5, 2022
@jtoar jtoar removed the v1/priority label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants