Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.1.x] kafka/server: run activate_feature in background #4564

Merged
merged 3 commits into from
May 4, 2022
Merged

[v22.1.x] kafka/server: run activate_feature in background #4564

merged 3 commits into from
May 4, 2022

Commits on May 4, 2022

  1. stop_signal: Signal in destructor 

    Some unit tests does not finish, because background tasks for
group_migration_metadata does not get request abort

(cherry picked from commit 5fbe5aa)
    @VadimPlh @vbotbuildovich
    VadimPlh authored and vbotbuildovich committed May 4, 2022
    Configuration menu
    Copy the full SHA
    7510a20 View commit details
    Browse the repository at this point in the history

  2. kafka/server: run activate_feature in background 

    Ufter upgrading node in cluster to 22.1.x version from 22.11.x
upgraded node isn't controller leade, it enters group_metadata_migration::start
and hits the "kafka_internal/group topic does not exists, activating" path
this call waits for activate_feature,activate_feature loops until the feature is active,
but it cannot be activated because only the controller leader runs the feature_manager
logic for activating features, and the controller leader is a 21.11.x node
that doesn't have the code. The node remains in 'booting' state indefinitely

Fixes: redpanda-data#4469
(cherry picked from commit b7fb5bd)
    @VadimPlh @vbotbuildovich
    VadimPlh authored and vbotbuildovich committed May 4, 2022
    Configuration menu
    Copy the full SHA
    799d3ce View commit details
    Browse the repository at this point in the history

  3. tests: added migration test when group topic is not present 

    Signed-off-by: Michal Maslanka <[email protected]>
(cherry picked from commit dc4f77c)
    @mmaslankaprv @dotnwat
    mmaslankaprv authored and dotnwat committed May 4, 2022
    Configuration menu
    Copy the full SHA
    699eda0 View commit details
    Browse the repository at this point in the history