[v22.1.x] kafka/server: run activate_feature in background #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some unit tests does not finish, because background tasks for group_migration_metadata does not get request abort (cherry picked from commit 5fbe5aa)
Ufter upgrading node in cluster to 22.1.x version from 22.11.x upgraded node isn't controller leade, it enters group_metadata_migration::start and hits the "kafka_internal/group topic does not exists, activating" path this call waits for activate_feature,activate_feature loops until the feature is active, but it cannot be activated because only the controller leader runs the feature_manager logic for activating features, and the controller leader is a 21.11.x node that doesn't have the code. The node remains in 'booting' state indefinitely Fixes: redpanda-data#4469 (cherry picked from commit b7fb5bd)
Signed-off-by: Michal Maslanka <[email protected]> (cherry picked from commit dc4f77c)
dotnwat
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from pull request: #4474
Fixes #4563
Also includes backport for: #4547 which is a test for #4474