Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud_roles: replace boost::string_view with std::string_view #14312

Merged

Conversation

abhijat
Copy link
Contributor

@abhijat abhijat commented Oct 20, 2023

The boost::core::string_view returned by boost::beast helpers seems to break OSS build.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

The boost::core::string_view returned by boost::beast helpers seems to
break OSS build.
@abhijat abhijat force-pushed the issue/replace-boost-string-view-with-std branch from 0575767 to 6a03ad7 Compare October 20, 2023 14:57
@abhijat abhijat marked this pull request as ready for review October 20, 2023 17:14
@vbotbuildovich
Copy link
Collaborator

@abhijat abhijat merged commit b1f265e into redpanda-data:dev Oct 20, 2023
25 checks passed
@abhijat
Copy link
Contributor Author

abhijat commented Oct 23, 2023

Th backport for this PR is applied by manually cherry picking the commit onto these PRs:

#14307
#14306
#14308

The three PRs have broken build-oss which this cherry-pick fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants