Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.1.x] cloud_roles: redact fields from request string representation #14306

Merged
merged 3 commits into from
Oct 23, 2023
Merged

[v23.1.x] cloud_roles: redact fields from request string representation #14306

merged 3 commits into from
Oct 23, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #14271

@abhijat @vbotbuildovich
http: Move redacted fields to a public method
12a88fc 
This allows other units of code to call it.

(cherry picked from commit 2d7dcf4)
@abhijat @vbotbuildovich
cloud_roles: Redact fields when printing request
55aa789 
When printing a request the fields inside the string can leak secrets. A
replacement is done inside the string for sensitive headers.

(cherry picked from commit 044ec1e)
@vbotbuildovich vbotbuildovich added this to the v23.1.x-next milestone Oct 20, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Oct 20, 2023
@abhijat abhijat marked this pull request as ready for review October 20, 2023 14:23
@abhijat
cloud_roles: replace boost::string_view with std::string_view
25f55ee 
The boost::core::string_view returned by boost::beast helpers seems to
break OSS build.
@abhijat abhijat mentioned this pull request Oct 23, 2023
Merged
7 tasks
@abhijat abhijat merged commit 836d9d3 into redpanda-data:v23.1.x Oct 23, 2023
21 checks passed
@piyushredpanda piyushredpanda modified the milestones: v23.1.x-next, v23.1.20 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijat abhijat abhijat approved these changes

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@vbotbuildovich @abhijat @piyushredpanda