Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

co_await mutex hold in conn_quota #12756

Merged

Conversation

rockwotj
Copy link
Contributor

We need to await acquiring this lock. Found via grep after #12755

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

We need to await acquiring this lock. Found via grep after redpanda-data#12755

Signed-off-by: Tyler Rockwood <[email protected]>
Copy link
Contributor

@andrwng andrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I'm pretty sure this fixes a shutdown hang seen in e2e_shadow_indexing_test. I suspect this was causing a lock order inversion/deadlock, maybe with the conn_quota::units

@rockwotj rockwotj merged commit 0e9176f into redpanda-data:dev Aug 12, 2023
26 checks passed
@rockwotj rockwotj deleted the rockwood/co_await_conn_quota_mutex branch August 12, 2023 17:36
@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v22.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants