Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e_shadow_indexing_test: bump timeout for workload #11828

Merged

Conversation

andrwng
Copy link
Contributor

@andrwng andrwng commented Jul 1, 2023

Empirically, segments may be uploaded ~1/partition/sec, particularly on dockeriszed environments. Thus, the current timeout for the number of segments we want to generate is flaky.

Fixes #11268

Also fixes slow scrubbing, from when there are too many segments to analyze in 30s.

Fixes #11698

Remaining flakiness appears to be fixed by #12756

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

  • none

@andrwng
Copy link
Contributor Author

andrwng commented Jul 1, 2023

/ci-repeat 4
release
skip-units
dt-repeat=10
tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingManyPartitionsTest.test_many_partitions_shutdown

@andrwng
Copy link
Contributor Author

andrwng commented Jul 1, 2023

/ci-repeat 8
release
skip-units
dt-repeat=5
tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingManyPartitionsTest.test_many_partitions_shutdown

@andrwng
Copy link
Contributor Author

andrwng commented Jul 1, 2023

/ci-repeat 7
release
skip-units
dt-repeat=7
tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingManyPartitionsTest.test_many_partitions_shutdown

@andrwng
Copy link
Contributor Author

andrwng commented Jul 7, 2023

CI failures: #11944

@andrwng
Copy link
Contributor Author

andrwng commented Jul 7, 2023

/cdt tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingManyPartitionsTest.test_many_partitions_shutdown dt-repeat=10 dt-log-level=debug

@andrwng andrwng force-pushed the many-partitions-shutdown-bump branch from eb00e60 to 67d255c Compare July 7, 2023 22:42
@andrwng
Copy link
Contributor Author

andrwng commented Jul 8, 2023

/cdt tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingManyPartitionsTest.test_many_partitions_shutdown dt-repeat=10 dt-log-level=debug

@piyushredpanda
Copy link
Contributor

Is this close to done, @andrwng ? These issues are failing quite a bit.

@andrwng
Copy link
Contributor Author

andrwng commented Jul 10, 2023

Is this close to done, @andrwng ? These issues are failing quite a bit.

The fixes have so far whittled the failures down to just the shutdown hang, which seems fairly reliable in CDT. Adding more debug logging to debug; hopefully will get to the root cause today.

@andrwng
Copy link
Contributor Author

andrwng commented Jul 10, 2023

/cdt tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingManyPartitionsTest.test_many_partitions_shutdown dt-repeat=3 dt-log-level=trace

@andrwng
Copy link
Contributor Author

andrwng commented Jul 10, 2023

/ci-repeat

@andrwng
Copy link
Contributor Author

andrwng commented Jul 10, 2023

/cdt tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingManyPartitionsTest.test_many_partitions_shutdown dt-repeat=3 dt-log-level=trace

1 similar comment
@andrwng
Copy link
Contributor Author

andrwng commented Jul 11, 2023

/cdt tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingManyPartitionsTest.test_many_partitions_shutdown dt-repeat=3 dt-log-level=trace

@andrwng
Copy link
Contributor Author

andrwng commented Jul 11, 2023

The latest runs show the Kafker server's net::server::_conn_gate being held up.

@andrwng
Copy link
Contributor Author

andrwng commented Jul 22, 2023

/ci-repeat
release
skip-units

Empirically, segments may be uploaded ~1/partition/sec, particularly on
dockeriszed environments. Thus, the current timeout for the number of
segments we want to generate is flaky.
@andrwng andrwng force-pushed the many-partitions-shutdown-bump branch 2 times, most recently from e0e1065 to 810069e Compare August 13, 2023 04:32
@andrwng
Copy link
Contributor Author

andrwng commented Aug 13, 2023

/cdt tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingManyPartitionsTest.test_many_partitions_shutdown dt-repeat=30

@andrwng andrwng marked this pull request as ready for review August 14, 2023 00:30
This makes the final cloud storage scrub timeout configurable for tests
that expect to write a lot of data.
In CDT this test could end up generating way more data than in
dockerized tests, resulting in the consume workload taking much longer
than expected.

This patch reduces the workload to ensure a more reasonable runtime.
@andrwng andrwng force-pushed the many-partitions-shutdown-bump branch from 810069e to 60a0614 Compare August 14, 2023 04:37
@piyushredpanda
Copy link
Contributor

Failure is #12104

@piyushredpanda piyushredpanda merged commit 7025bc4 into redpanda-data:dev Aug 14, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants