Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: profile globals rename #12088

Merged
merged 5 commits into from
Jul 14, 2023
Merged

rpk: profile globals rename #12088

merged 5 commits into from
Jul 14, 2023

Commits on Jul 13, 2023

  1. rpk: rename defaults -> globals 

    Global rpk configs apply to all profiles, so it's
a little bit clearer.
    @r-vasquez
    r-vasquez committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    bd241a8 View commit details
    Browse the repository at this point in the history

  2. rpk: add prompt to set/flag autocompletion in profile

    @r-vasquez
    r-vasquez committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d2e854e View commit details
    Browse the repository at this point in the history

  3. rpk: rename redpanda_client_id global config 

    to kafka_protocol_request_client_id
    @r-vasquez
    r-vasquez committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d4786de View commit details
    Browse the repository at this point in the history

  4. rpk: add name by default to the prompt if not empty 

    If a user has a prompt but no "%p" nor "%n" then
we will print the name.
    @r-vasquez
    r-vasquez committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    8297ddf View commit details
    Browse the repository at this point in the history

  5. rpk: reword confirmation message for topic trim 

    So its clearer that it's a destructive action.
    @r-vasquez
    r-vasquez committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    6e69361 View commit details
    Browse the repository at this point in the history