Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: profile globals rename #12088

Merged
merged 5 commits into from
Jul 14, 2023
Merged

rpk: profile globals rename #12088

merged 5 commits into from
Jul 14, 2023

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Jul 13, 2023 •
edited
Loading

Addressing a few feedbacks:

  • Renaming profile defaults -> globals.
  • Defaulting to printing the name of the profile in rpk profile prompt if the prompt string is not empty.
  • Renaming redpanda_client_id to kafka_protocol_request_client_id
  • Reword of confirmation prompt text in rpk topic trim

Backports Required

  • none - issue does not exist in previous branches

These features have not been released yet:

Release Notes

  • none

@r-vasquez
rpk: rename defaults -> globals
bd241a8 
Global rpk configs apply to all profiles, so it's
a little bit clearer.
@r-vasquez
rpk: add prompt to set/flag autocompletion in profile
d2e854e
@r-vasquez
rpk: rename redpanda_client_id global config
d4786de 
to kafka_protocol_request_client_id
@r-vasquez
rpk: add name by default to the prompt if not empty
8297ddf 
If a user has a prompt but no "%p" nor "%n" then
we will print the name.
@r-vasquez
rpk: reword confirmation message for topic trim
6e69361 
So its clearer that it's a destructive action.
@r-vasquez r-vasquez requested a review from twmb July 13, 2023 22:22
@twmb twmb added this to the v23.2.1 milestone Jul 14, 2023
This was referenced Jul 14, 2023
Closed
Closed
@michael-redpanda
Copy link
Contributor

michael-redpanda commented Jul 14, 2023 •
edited
Loading

CI Failures:

@twmb twmb merged commit 85e98ec into redpanda-data:dev Jul 14, 2023
@twmb twmb deleted the rpk-profile-globals branch July 14, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twmb twmb twmb approved these changes

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
v23.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@r-vasquez @michael-redpanda @twmb