Fix for delete-records tests that don't handle RpkExceptions #11963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now that trim_prefix throws if any topic trim results in any error, rpktool will throw - Tests that assert on a particular error must account for this - Fixes: redpanda-data#11961
andrwng
previously approved these changes
Jul 8, 2023
- In a previous commit KCL::delete_records was depricated in favor of RpkTools but the update was never made to the invocation of the call in the read_replica and shadow indexing suites
graphcareful
force-pushed
the
fix-rpk-delete-records
branch
from
3810a28
to
175c930
Compare
andrwng
approved these changes
Jul 8, 2023
|
Known CI Failures: #11842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #11957 introduced a behavior change in how rpk topic trim handles on observed errors. It now returns a processes exit code of 1 if there is any failure detected. This change is making the ducktape Rpk client throw on errors which is making some tests that expect failures actually fail.
This PR also includes a fix for another error which was making the read replica delete records test fail. That test invoked KCL::DeleteRecords which was deprecated without updating that test to use the Rpk tools version of the same command.
Backports Required
Release Notes