Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage] space management bug fixes and logging improvements #11768

Merged
merged 3 commits into from
Jun 29, 2023
Merged

[storage] space management bug fixes and logging improvements #11768

merged 3 commits into from
Jun 29, 2023

Commits on Jun 28, 2023

  1. rmgmt: improve space management logging 

    Info level is yes likely too high for some of these. But it only runs in
low-disk situations, and is useful in the short term to have for
debugging.

Signed-off-by: Noah Watkins <[email protected]>
    @dotnwat
    dotnwat committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    c0899f2 View commit details
    Browse the repository at this point in the history

  2. rmgmt: fix bug resulting in slow retention overrides 

    1. Was only choosing the offset of the first eligible segment
2. Was only reporting one segment from each partition as eligible

Taken together, the reclaim rate was depending on how often the control
loop ran rather than how fast data was uploaded into the cloud.

Signed-off-by: Noah Watkins <[email protected]>
    @dotnwat
    dotnwat committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    830ebf7 View commit details
    Browse the repository at this point in the history

  3. rmgmt: decrease control loop frequency 

    This is now possible by fixing the bug in the previous commit. Also
reducing the timeout on the test because it works much better without
that previous bug!

Signed-off-by: Noah Watkins <[email protected]>
    @dotnwat
    dotnwat committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    9f60e73 View commit details
    Browse the repository at this point in the history