[storage] space management bug fixes and logging improvements #11768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Info level is yes likely too high for some of these. But it only runs in low-disk situations, and is useful in the short term to have for debugging. Signed-off-by: Noah Watkins <[email protected]>
1. Was only choosing the offset of the first eligible segment 2. Was only reporting one segment from each partition as eligible Taken together, the reclaim rate was depending on how often the control loop ran rather than how fast data was uploaded into the cloud. Signed-off-by: Noah Watkins <[email protected]>
This is now possible by fixing the bug in the previous commit. Also reducing the timeout on the test because it works much better without that previous bug! Signed-off-by: Noah Watkins <[email protected]>
andrwng
approved these changes
Jun 29, 2023
| @@ -593,4 +593,4 @@ def target_size_reached(): | |||
| return total < (15 * 2**20 + 2 * self.log_segment_size) | |||
|
|
|||
| # give it plenty of time. on debug it is hella slow | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes