Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory-sampling: Reduce reactor count for mem sampling tests #11518

Commits on Jun 17, 2023

  1. memory-sampling: Reduce reactor count for mem sampling tests

    In those tests we set a `std::stringstream` for the seastar logger so that
    we can actually test what is being logged.
    
    However, in contrast to `std::cerr` `std::stringstream` is of course not
    threadsafe so if multiple reactors try to log at the same time things go
    wrong.
    
    Ideally we could just use `<syncstream>` but libc++ doesn't support that
    yet. Hence, just run the tests with only a single reactor thread.
    
    Additionally properly stop the services.
    
    Issue redpanda-data#11513
    StephanDollberg committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    6ab7dee View commit details
    Browse the repository at this point in the history