memory-sampling: Reduce reactor count for mem sampling tests #11518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In those tests we set a `std::stringstream` for the seastar logger so that we can actually test what is being logged. However, in contrast to `std::cerr` `std::stringstream` is of course not threadsafe so if multiple reactors try to log at the same time things go wrong. Ideally we could just use `<syncstream>` but libc++ doesn't support that yet. Hence, just run the tests with only a single reactor thread. Additionally properly stop the services. Issue redpanda-data#11513
mmaslankaprv
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In those tests we set a
std::stringstreamfor the seastar logger so thatwe can actually test what is being logged.
However, in contrast to
std::cerrstd::stringstreamis of course notthreadsafe so if multiple reactors try to log at the same time things go
wrong.
Ideally we could just use
<syncstream>but libc++ doesn't support thatyet. Hence, just run the tests with only a single reactor thread.
Additionally properly stop the services.
Issue #11513
Backports Required
Release Notes