Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update start timeout for leadership_transfer_test on debug builds #11472

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

ballard26
Copy link
Contributor

@ballard26 ballard26 commented Jun 16, 2023

This PR updates the node start timeout of this test to 60 seconds for debug builds. The need for this change comes from the 500+ partitions this test creates which leads to the node starting up 6 times slower compared to an empty node when on a debug build. This change wasn't needed originally, however, with the update to clang-16 there seems to be a slight performance regression in our debug builds causing the node start time to be right around 20s.

Fixes #11044

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

  • none

Copy link
Contributor

@bharathv bharathv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once a repeat run passes.

@piyushredpanda
Copy link
Contributor

#10497
#11454
#11276

@piyushredpanda piyushredpanda merged commit 0c566bd into redpanda-data:dev Jun 16, 2023
@vbotbuildovich
Copy link
Collaborator

/backport v23.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v22.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v22.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to run cherry-pick command. I executed the commands below:

git checkout -b backport-pr-11472-v22.3.x-778 remotes/upstream/v22.3.x
git cherry-pick -x 45c8c5d24d8717a95637902c036d1a26ffcfa19b

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Failed to run cherry-pick command. I executed the commands below:

git checkout -b backport-pr-11472-v22.2.x-529 remotes/upstream/v22.2.x
git cherry-pick -x 45c8c5d24d8717a95637902c036d1a26ffcfa19b

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants