Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k/proto: use log-level warn for missmatch crc #11324

Merged
merged 2 commits into from
Jun 9, 2023
Merged

k/proto: use log-level warn for missmatch crc #11324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b01f4
k/proto: use log-level warn for missmatch crc
NyaliaLui Jun 9, 2023
41d7317
tests/cloud: remove missmatch CRC from allow list
NyaliaLui Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/v/kafka/protocol/kafka_batch_adapter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ void kafka_batch_adapter::verify_crc(int32_t expected_crc, iobuf_parser in) {
if (unlikely((uint32_t)expected_crc != crc.value())) {
valid_crc = false;
vlog(
klog.error,
klog.warn,
"Cannot validate Kafka record batch. Missmatching CRC. Expected:{}, "
"Got:{}",
expected_crc,
Expand Down
9 changes: 1 addition & 8 deletions tests/rptest/scale_tests/cloud_storage_compaction_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,14 +162,7 @@ def _setup_read_replica(self):
timeout_sec=30,
backoff_sec=5)

# Permit transient CRC errors, to protect this test from incidences of
# https://github.com/redpanda-data/redpanda/issues/6631
# TODO: remove this low allow-list when that issue is resolved.
@cluster(num_nodes=9,
log_allow_list=[
"Cannot validate Kafka record batch. Missmatching CRC",
"batch has invalid CRC"
])
@cluster(num_nodes=9)
@matrix(
cloud_storage_type=get_cloud_storage_type(docker_use_arbitrary=True))
def test_read_from_replica(self, cloud_storage_type):
Expand Down