k/proto: use log-level warn for missmatch crc #11324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyaliaLui
requested review from
dotnwat,
bharathv,
mmaslankaprv and
piyushredpanda
It was revealed that upstream kafka will ignore this error. Therefore, RP should not log it at a high severity. Fixes redpanda-data#6631 Fixes redpanda-data#10169
NyaliaLui
force-pushed
the
missmatch-crc-as-warning
branch
from
1202fec
to
41d7317
Compare
|
/backport v23.1.x |
|
/backport v22.3.x |
|
/backport v22.2.x |
|
Failed to run cherry-pick command. I executed the commands below: |
|
Failed to run cherry-pick command. I executed the commands below: |
This was referenced Jun 9, 2023
|
Failed to run cherry-pick command. I executed the commands below: |
This was referenced Jun 9, 2023
NyaliaLui
added a commit
to NyaliaLui/redpanda
that referenced
this pull request
Jun 13, 2023
Recently, redpanda-data#11324 changed the log-level from error to warn for a CRC missmatch. However, on the same event, RP will also log "batch has invalid CRC" at the error level. This commit therefore changes the log for "batch has invalid CRC" to warn level. Fixes redpanda-data#11361
7 tasks
vbotbuildovich
pushed a commit
to vbotbuildovich/redpanda
that referenced
this pull request
Jun 13, 2023
Recently, redpanda-data#11324 changed the log-level from error to warn for a CRC missmatch. However, on the same event, RP will also log "batch has invalid CRC" at the error level. This commit therefore changes the log for "batch has invalid CRC" to warn level. Fixes redpanda-data#11361 (cherry picked from commit d4b9b9c)
vbotbuildovich
pushed a commit
to vbotbuildovich/redpanda
that referenced
this pull request
Jun 13, 2023
Recently, redpanda-data#11324 changed the log-level from error to warn for a CRC missmatch. However, on the same event, RP will also log "batch has invalid CRC" at the error level. This commit therefore changes the log for "batch has invalid CRC" to warn level. Fixes redpanda-data#11361 (cherry picked from commit d4b9b9c)
vbotbuildovich
pushed a commit
to vbotbuildovich/redpanda
that referenced
this pull request
Jun 13, 2023
Recently, redpanda-data#11324 changed the log-level from error to warn for a CRC missmatch. However, on the same event, RP will also log "batch has invalid CRC" at the error level. This commit therefore changes the log for "batch has invalid CRC" to warn level. Fixes redpanda-data#11361 (cherry picked from commit d4b9b9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was revealed that upstream kafka will ignore this error. Therefore, RP should not log it at a high severity. For more context, see the slack thread https://redpandadata.slack.com/archives/C044RD18NMV/p1686288964523829?thread_ts=1686229938.913769&cid=C044RD18NMV
Changes from force-push
41d7317:Fixes #6631
Fixes #10169
Backports Required
Release Notes