Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address clang16 use after move #11018

Merged
merged 18 commits into from
May 25, 2023
Merged

Address clang16 use after move #11018

merged 18 commits into from
May 25, 2023

Commits on May 24, 2023

  1. kafka/create_topics: removed mix of continuations and coroutines 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 24, 2023
    Configuration menu
    Copy the full SHA
    af017e3 View commit details
    Browse the repository at this point in the history

  2. kafka/group: Addressed false positive use-after-move 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 24, 2023
    Configuration menu
    Copy the full SHA
    2c97d23 View commit details
    Browse the repository at this point in the history

  3. kafka/connection_context: Addressed false positive use-after-move 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 24, 2023
    Configuration menu
    Copy the full SHA
    6f0aa6c View commit details
    Browse the repository at this point in the history

  4. cloud_storage: Addressed false positive use-after-move in s3_client.cc 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 24, 2023
    Configuration menu
    Copy the full SHA
    808b2c8 View commit details
    Browse the repository at this point in the history

  5. cluster: Addressed false positive use-after-move in non_replicable_to… 

    …pics_frontend.cc

The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 24, 2023
    Configuration menu
    Copy the full SHA
    c164a04 View commit details
    Browse the repository at this point in the history

  6. cluster: Addressed false positive use-after-move in topic_updates_dis… 

    …patcher

The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 24, 2023
    Configuration menu
    Copy the full SHA
    67e74ae View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. raft: Addressed false positive use-after-move in consensus.cc 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    def8b69 View commit details
    Browse the repository at this point in the history

  2. rpc: Addressed false positive use-after-move in rpc_server.cc 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    f1314a1 View commit details
    Browse the repository at this point in the history

  3. cluster: Addressed false positive use-after-move in partition_balance… 

    …r_backend.cc

The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    e358753 View commit details
    Browse the repository at this point in the history

  4. utils: Addressed false positive use-after-move 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    d422deb View commit details
    Browse the repository at this point in the history

  5. k/client: Addressed false positive use-after-move 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    cbab554 View commit details
    Browse the repository at this point in the history

  6. raft: Addressed false positive use-after-move 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

The use of NOLINTBEGIN/NOLINTEND comments is an alternative to copying
`opts` that may degrade performance.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    411aed9 View commit details
    Browse the repository at this point in the history

  7. cluster: Addressed false positive use-after-move in topics_frontend.cc 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    a43cadc View commit details
    Browse the repository at this point in the history

  8. k/client: Addressed false positive use-after-move 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    b61eb38 View commit details
    Browse the repository at this point in the history

  9. cluster: Addressed false positive use-after-move 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    7ec3ce3 View commit details
    Browse the repository at this point in the history

  10. cluster: Fix use-after-move in set_initial_state 

    Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    30e26c4 View commit details
    Browse the repository at this point in the history

  11. pp: Addressed false positive use-after-move 

    The motivation for this was because `clang-tidy` was throwing a possible
false-positive use-after-move.

Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    a84b8b6 View commit details
    Browse the repository at this point in the history

  12. all: lint commit 

    Signed-off-by: Michael Boquard <[email protected]>
    @michael-redpanda
    michael-redpanda committed May 25, 2023
    Configuration menu
    Copy the full SHA
    a4404ab View commit details
    Browse the repository at this point in the history