Address clang16 use after move #11018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
…pics_frontend.cc The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
…patcher The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
dotnwat
previously requested changes
May 24, 2023
dotnwat
reviewed
May 24, 2023
dotnwat
reviewed
May 24, 2023
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
…r_backend.cc The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
michael-redpanda
force-pushed
the
address-clang16-use-after-move
branch
from
ae31b41
to
f7f1d66
Compare
dotnwat
reviewed
May 25, 2023
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. The use of NOLINTBEGIN/NOLINTEND comments is an alternative to copying `opts` that may degrade performance. Signed-off-by: Michael Boquard <[email protected]>
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
Signed-off-by: Michael Boquard <[email protected]>
The motivation for this was because `clang-tidy` was throwing a possible false-positive use-after-move. Signed-off-by: Michael Boquard <[email protected]>
michael-redpanda
force-pushed
the
address-clang16-use-after-move
branch
from
8e21f14
to
a84b8b6
Compare
Signed-off-by: Michael Boquard <[email protected]>
BenPope
approved these changes
May 25, 2023
| append_topic_configs(ctx, response); | ||
| } | ||
|
|
||
| co_return co_await ctx.respond(response); |
There was a problem hiding this comment.
nit: Could move response. (but this refactor is correct)
dotnwat
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-tidy-16reported a number of false positive 'use-after-move' errors. This PR addresses thoseThis appears to be a false-positive, as indicated here: llvm/llvm-project#59612
Backports Required
Release Notes