Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user timelines missing fields #341

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

redouane59
Copy link
Owner

fixing #340

@sonarcloud
Copy link

sonarcloud bot commented Dec 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@redouane59 redouane59 linked an issue Dec 10, 2021 that may be closed by this pull request
@redouane59 redouane59 merged commit 9010d71 into develop Dec 10, 2021
@redouane59 redouane59 deleted the feat_add_user_timelines_fields branch December 10, 2021 09:27
@redouane59 redouane59 mentioned this pull request Dec 10, 2021
@jormungander
Copy link

I think ALL_EXPANSIONS needs to include geo.place_id in order for the places to get added to the includes structure.

@redouane59
Copy link
Owner Author

redouane59 commented Jan 12, 2022

Hey @jormungander . Really ? Adding it to ALL_PLACE_FIELDS is not enough ?

@jormungander
Copy link

Yes. The ALL_PLACE_FIELDS in place.fields tells it which fields to include, but it's the presence of the geo.place_id in expansions which tells Twitter's API whether to put those fields in the includes or not, basically an on/off switch. I've verified this with the API collection Twitter provides for Postman.

@redouane59
Copy link
Owner Author

Thanks, it is fixed and will be available on the next release : #352

@jormungander
Copy link

I just got around to checking this and I see there's more to it. The Includes class that the TweetList uses (which comes from TweetV2) does not contain a List to put the places data that it's receiving.

@redouane59
Copy link
Owner Author

redouane59 commented Feb 2, 2022

Could you please submit a pull request @jormungander ?
edit : just did it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional data for timeline tweets
2 participants