Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add geo id to all_expansions #352

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Conversation

redouane59
Copy link
Owner

No description provided.

@gitguardian
Copy link

gitguardian bot commented Jan 12, 2022

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic High Entropy Secret 594f0c9 test-twitter-credentials.json 17:51 January 12th, 2022 View secret
Generic High Entropy Secret a9b6a1b test-twitter-credentials.json 17:51 January 12th, 2022 View secret
Generic High Entropy Secret 594f0c9 test-twitter-credentials.json 17:51 January 12th, 2022 View secret
Generic High Entropy Secret a9b6a1b test-twitter-credentials.json 17:51 January 12th, 2022 View secret
Generic High Entropy Secret 594f0c9 test-twitter-credentials.json 17:51 January 12th, 2022 View secret
Generic High Entropy Secret a9b6a1b test-twitter-credentials.json 17:51 January 12th, 2022 View secret
Generic High Entropy Secret 594f0c9 test-twitter-credentials.json 17:51 January 12th, 2022 View secret
Generic High Entropy Secret a9b6a1b test-twitter-credentials.json 17:51 January 12th, 2022 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

@redouane59 redouane59 force-pushed the feat_add_geo_id_to_all_fields branch from 0c43eaf to a9b6a1b Compare January 12, 2022 17:51
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@redouane59 redouane59 marked this pull request as ready for review January 12, 2022 17:55
@redouane59 redouane59 merged commit e96c24d into develop Jan 12, 2022
@redouane59 redouane59 deleted the feat_add_geo_id_to_all_fields branch January 12, 2022 18:13
@redouane59 redouane59 mentioned this pull request Jan 12, 2022
redouane59 added a commit that referenced this pull request Jan 21, 2022
* fix: chunked tweet JSON parse exception (#348)

* fix: Chunked tweet JSON object

* fix version

* feat: add geo id to all_expansions (#352)

* feat: add geo id to all_expansions

* push c

* feat: pagination for likes and retweets endpoints (#353)

* feat: pagination for likes and retweets endpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant