Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stackoverflow exception inside CommandLatencyCollectorOptions #899

Conversation

LarryBattle
Copy link
Contributor

Problem:

CommandLatencyCollectorOptions.builder() calls itself to form a stackoverflow exception.

Solution:

CommandLatencyCollectorOptions.builder() now calls DefaultCommandLatencyCollectorOptions.builder()

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #899 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #899      +/-   ##
===========================================
- Coverage     81.07%     81%   -0.07%     
+ Complexity     5703    5701       -2     
===========================================
  Files           409     409              
  Lines         18445   18445              
  Branches       2131    2131              
===========================================
- Hits          14954   14942      -12     
- Misses         2479    2494      +15     
+ Partials       1012    1009       -3
Impacted Files Coverage Δ Complexity Δ
...e/core/metrics/CommandLatencyCollectorOptions.java 33.33% <100%> (+33.33%) 1 <1> (+1) ⬆️
...io/lettuce/core/masterslave/SentinelConnector.java 65% <0%> (-17.5%) 6% <0%> (-2%)
...ttuce/core/support/ClientResourcesFactoryBean.java 46.66% <0%> (-13.34%) 4% <0%> (-1%)
src/main/java/io/lettuce/core/ScanStream.java 75% <0%> (-5.27%) 25% <0%> (ø)
...uce/core/masterslave/SentinelTopologyProvider.java 80.55% <0%> (-2.78%) 9% <0%> (-2%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 82.43% <0%> (-2.71%) 1% <0%> (ø)
...e/core/metrics/DefaultCommandLatencyCollector.java 76.66% <0%> (-0.84%) 22% <0%> (ø)
...main/java/io/lettuce/core/AbstractRedisClient.java 75.86% <0%> (-0.5%) 43% <0%> (-1%)
...tuce/core/masterslave/SentinelTopologyRefresh.java 84.86% <0%> (ø) 35% <0%> (+2%) ⬆️
...java/io/lettuce/core/protocol/DefaultEndpoint.java 69.68% <0%> (+0.51%) 89% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e58b5...6d6c817. Read the comment docs.

@mp911de mp911de added the type: bug A general bug label Oct 25, 2018
@mp911de mp911de added this to the 5.1.2 milestone Oct 25, 2018
mp911de added a commit that referenced this pull request Oct 25, 2018
Add author tag. Rename previously wrong named test.
mp911de added a commit that referenced this pull request Oct 25, 2018
Add author tag. Rename previously wrong named test.
@mp911de
Copy link
Collaborator

mp911de commented Oct 25, 2018

Thanks a lot for the fix. That's merged, polished, and backported now.

@mp911de mp911de closed this Oct 25, 2018
@LarryBattle LarryBattle deleted the bug_fix/stackoverflow_when_createing_builder branch October 26, 2018 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants