Skip to content

Commit

Permalink
Fixed StackOverflow caused CommandLatencyCollectorOptions.builder() #899
Browse files Browse the repository at this point in the history
  • Loading branch information
LarryBattle authored and mp911de committed Oct 25, 2018
1 parent 693b71a commit 240aea0
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ static CommandLatencyCollectorOptions disabled() {
* @since 5.1
*/
static CommandLatencyCollectorOptions.Builder builder() {
return CommandLatencyCollectorOptions.builder();
return DefaultCommandLatencyCollectorOptions.builder();
}

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
/*
* Copyright 2011-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.lettuce.core.metrics;

import org.junit.jupiter.api.Test;

import java.util.concurrent.TimeUnit;

import static org.assertj.core.api.Assertions.assertThat;

class CommandLatencyCollectorOptionsUnitTests {

@Test()
void testBuilder() {

CommandLatencyCollectorOptions sut = CommandLatencyCollectorOptions.builder()
.targetUnit(TimeUnit.HOURS).targetPercentiles(new double[] { 1, 2, 3 }).build();

assertThat(sut.targetPercentiles()).hasSize(3);
assertThat(sut.targetUnit()).isEqualTo(TimeUnit.HOURS);
}
}

0 comments on commit 240aea0

Please sign in to comment.