-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to provide a custom service name for spans #866
Conversation
Codecov Report
@@ Coverage Diff @@
## master #866 +/- ##
============================================
- Coverage 81.14% 81.13% -0.02%
+ Complexity 5691 5688 -3
============================================
Files 409 409
Lines 18328 18342 +14
Branches 2126 2126
============================================
+ Hits 14873 14882 +9
- Misses 2438 2443 +5
Partials 1017 1017
Continue to review full report at Codecov.
|
I noticed the travis tests are a bit flaky. Rerunning will cause different tests to fail (unrelated to these changes). |
…n of code to create brave tracing)
I noticed there was some duplication of ways to instantiate some objects. Not sure if this is by design so I did the same and added static methods for both a default create and a builder in both the interface (Tracing) and implementation (BraveTracing). |
Remove builder interface from Tracing to prevent implementation-specific dependencies. Move brave.Tracing dependency into builder configuration method to avoid builder constructor with args. Add customization hooks for Endpoint and Span types to apply further customizations. Split BraveTracingIntegrationTests into unit and integration tests. Add author tag, reformat code. Rollback release notes change as we do not change already released bits.
Thanks a lot. That's merged and polished now. |
Awesome. Thanks :) |
Issue described here: #865