Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to provide a custom service name for spans #866

Closed
wants to merge 3 commits into from

Conversation

worldtiki
Copy link
Contributor

Issue described here: #865

@worldtiki worldtiki closed this Sep 25, 2018
@worldtiki worldtiki reopened this Sep 25, 2018
@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #866 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #866      +/-   ##
============================================
- Coverage     81.14%   81.13%   -0.02%     
+ Complexity     5691     5688       -3     
============================================
  Files           409      409              
  Lines         18328    18342      +14     
  Branches       2126     2126              
============================================
+ Hits          14873    14882       +9     
- Misses         2438     2443       +5     
  Partials       1017     1017
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/lettuce/core/tracing/Tracing.java 57.14% <0%> (-22.86%) 4 <0> (ø)
...ain/java/io/lettuce/core/tracing/BraveTracing.java 80.76% <88.88%> (+0.46%) 8 <3> (+1) ⬆️
...uce/core/masterslave/SentinelTopologyProvider.java 80.55% <0%> (-2.78%) 9% <0%> (-1%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 79.72% <0%> (-2.1%) 38% <0%> (-1%)
.../io/lettuce/core/protocol/CommandExpiryWriter.java 73.07% <0%> (-1.93%) 15% <0%> (-1%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 85.13% <0%> (ø) 1% <0%> (ø) ⬇️
src/main/java/io/lettuce/core/RedisPublisher.java 80.66% <0%> (+0.37%) 5% <0%> (ø) ⬇️
.../java/io/lettuce/core/protocol/CommandHandler.java 76.9% <0%> (+0.81%) 102% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab8946...1eeabed. Read the comment docs.

@worldtiki
Copy link
Contributor Author

I noticed the travis tests are a bit flaky. Rerunning will cause different tests to fail (unrelated to these changes).

@worldtiki
Copy link
Contributor Author

I noticed there was some duplication of ways to instantiate some objects.
For example the ClientResources.create / ClientResources.builder and DefaultClientResources.create / DefaultClientResources.builder.

Not sure if this is by design so I did the same and added static methods for both a default create and a builder in both the interface (Tracing) and implementation (BraveTracing).

mp911de pushed a commit that referenced this pull request Oct 1, 2018
mp911de added a commit that referenced this pull request Oct 1, 2018
Remove builder interface from Tracing to prevent implementation-specific dependencies. Move brave.Tracing dependency into builder configuration method to avoid builder constructor with args. Add customization hooks for Endpoint and Span types to apply further customizations.

Split BraveTracingIntegrationTests into unit and integration tests. Add author tag, reformat code.

Rollback release notes change as we do not change already released bits.
@mp911de
Copy link
Collaborator

mp911de commented Oct 1, 2018

Thanks a lot. That's merged and polished now.

@mp911de mp911de closed this Oct 1, 2018
@worldtiki
Copy link
Contributor Author

Awesome. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants