Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BraveTracing should support custom names for the service name #865

Closed
worldtiki opened this issue Sep 25, 2018 · 3 comments
Closed

BraveTracing should support custom names for the service name #865

worldtiki opened this issue Sep 25, 2018 · 3 comments
Labels
type: feature A new feature
Milestone

Comments

@worldtiki
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe

It is likely for multiple Redis installations to coexist in a production environment.
Currently the service name for spans created by the Lettuce is hardcoded to "redis" which means that every service (using Lettuce client) will report spans with the service name "redis", regardless if they are using different Redis installations.

Describe the solution you'd like

There should be a builder for a BraveTracing that would allow users to provide a custom name to use for the service name for spans.

Describe alternatives you've considered

Didn't consider any alternatives.

Teachability, Documentation, Adoption, Migration Strategy

Currently a BraveTracing is created like this:
BraveTracing.create(tracing)
This could be changed to something like this (no name override):
BraveTracing.builder(tracing).build()
Or like this (with name override)
BraveTracing.builder(tracing).serviceName("customNameHere").build()

@worldtiki
Copy link
Contributor Author

Draft implementation here: #866 if it's easier to explain and discuss the proposed changes.

@mp911de
Copy link
Collaborator

mp911de commented Sep 25, 2018

Awesome improvement. Thanks a lot for submitting a pull request. Tests are sort of flaky on Travis CI so don't get distracted by that.

@mp911de mp911de added the type: feature A new feature label Oct 1, 2018
@mp911de mp911de added this to the 5.2.0 milestone Oct 1, 2018
mp911de pushed a commit that referenced this issue Oct 1, 2018
@mp911de
Copy link
Collaborator

mp911de commented Oct 1, 2018

I enhanced your PR with customization hooks for Span and Endpoint and applied a round of polishing. That's now on master.

@mp911de mp911de closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants