Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IDLE option in XPENDING #1636

Closed
wants to merge 2 commits into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Mar 2, 2021

Resolves #1537

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

# Conflicts:
#	src/test/java/io/lettuce/core/commands/StreamCommandIntegrationTests.java
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #1636 (445b499) into main (76e3bec) will decrease coverage by 0.00%.
The diff coverage is 78.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1636      +/-   ##
============================================
- Coverage     78.42%   78.42%   -0.01%     
- Complexity     6519     6528       +9     
============================================
  Files           486      487       +1     
  Lines         22035    22068      +33     
  Branches       2411     2415       +4     
============================================
+ Hits          17281    17306      +25     
- Misses         3641     3645       +4     
- Partials       1113     1117       +4     
Impacted Files Coverage Δ Complexity Δ
...pi/coroutines/RedisStreamCoroutinesCommandsImpl.kt 3.03% <0.00%> (-0.10%) 1.00 <0.00> (ø)
src/main/java/io/lettuce/core/XPendingArgs.java 76.00% <76.00%> (ø) 6.00 <6.00> (?)
...va/io/lettuce/core/AbstractRedisAsyncCommands.java 96.32% <100.00%> (+<0.01%) 468.00 <1.00> (+1.00)
...io/lettuce/core/AbstractRedisReactiveCommands.java 89.73% <100.00%> (+0.01%) 458.00 <1.00> (+1.00)
...main/java/io/lettuce/core/RedisCommandBuilder.java 95.48% <100.00%> (+0.01%) 513.00 <1.00> (+1.00)
.../io/lettuce/core/protocol/ReconnectionHandler.java 75.67% <0.00%> (-4.06%) 21.00% <0.00%> (-1.00%)
...e/core/masterreplica/SentinelTopologyProvider.java 81.08% <0.00%> (-2.71%) 9.00% <0.00%> (-1.00%)
.../io/lettuce/core/protocol/CommandExpiryWriter.java 75.00% <0.00%> (-1.93%) 16.00% <0.00%> (-1.00%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 86.52% <0.00%> (ø) 1.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e3bec...445b499. Read the comment docs.

@mp911de mp911de added this to the 6.1 RC1 milestone Mar 4, 2021
@mp911de mp911de added the type: feature A new feature label Mar 4, 2021
mp911de pushed a commit that referenced this pull request Mar 4, 2021
mp911de added a commit that referenced this pull request Mar 4, 2021
Add generic arguments to XPendingArgs builder and overloads accepting Duration. Add since tags.

Original pull request: #1636.
@mp911de
Copy link
Collaborator

mp911de commented Mar 4, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for IDLE option in XPENDING
2 participants