Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for IDLE option in XPENDING #1537

Closed
mp911de opened this issue Nov 30, 2020 · 1 comment
Closed

Add support for IDLE option in XPENDING #1537

mp911de opened this issue Nov 30, 2020 · 1 comment
Assignees
@dengliming
Labels
status: help-wanted An issue that a contributor can help us with type: feature A new feature
Milestone
6.1 RC1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Nov 30, 2020

See redis/redis#7972
@mp911de mp911de added the type: feature A new feature label Nov 30, 2020
@mp911de mp911de added this to the 6.1 M1 milestone Dec 15, 2020
@mp911de
Copy link
Collaborator Author

mp911de commented Jan 8, 2021

Given that we have already a few command overloads, we should introduce XPendingArgs to encapsulate Consumer<K> consumer, Range<String> range, Limit limit, and the idle option.

@mp911de mp911de added the status: help-wanted An issue that a contributor can help us with label Jan 13, 2021
@dengliming dengliming self-assigned this Jan 13, 2021
@mp911de mp911de modified the milestones: 6.1 M1, 6.1 RC1 Feb 8, 2021
@dengliming dengliming mentioned this issue Mar 2, 2021
Closed
4 tasks
mp911de pushed a commit that referenced this issue Mar 4, 2021
@dengliming @mp911de
Add support for IDLE option in XPENDING #1537
58a7628 
Original pull request: #1636.
mp911de added a commit that referenced this issue Mar 4, 2021
@mp911de
Polishing #1537
40dc25f 
Add generic arguments to XPendingArgs builder and overloads accepting Duration. Add since tags.

Original pull request: #1636.
@mp911de mp911de closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dengliming dengliming

Labels
status: help-wanted An issue that a contributor can help us with type: feature A new feature
Projects
None yet
Milestone
6.1 RC1
Development

Successfully merging a pull request may close this issue.

Add support for IDLE option in XPENDING dengliming/lettuce-core
2 participants
@mp911de @dengliming