Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement set(double) in NestedMultiOutput #1486

Merged
merged 5 commits into from
Nov 4, 2020
Merged

Implement set(double) in NestedMultiOutput #1486

merged 5 commits into from
Nov 4, 2020

Conversation

jruaux
Copy link
Contributor

@jruaux jruaux commented Oct 31, 2020

Added unit test for #1484

@jruaux jruaux changed the title Add unit test to #1484 Implement set(double) in NestedMultiOutput Oct 31, 2020
@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #1486 into main will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1486      +/-   ##
============================================
- Coverage     78.83%   78.81%   -0.02%     
- Complexity     6203     6208       +5     
============================================
  Files           461      461              
  Lines         20739    20745       +6     
  Branches       2282     2283       +1     
============================================
+ Hits          16349    16351       +2     
- Misses         3334     3336       +2     
- Partials       1056     1058       +2     
Impacted Files Coverage Δ Complexity Δ
...java/io/lettuce/core/output/NestedMultiOutput.java 84.84% <75.00%> (-1.36%) 12.00 <1.00> (+1.00) ⬇️
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 78.43% <0.00%> (-1.31%) 39.00% <0.00%> (ø%)
...java/io/lettuce/core/protocol/DefaultEndpoint.java 69.60% <0.00%> (-0.47%) 99.00% <0.00%> (ø%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 87.82% <0.00%> (ø) 1.00% <0.00%> (ø%)
.../java/io/lettuce/core/internal/LettuceStrings.java 64.51% <0.00%> (+5.89%) 19.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73711f7...ce19a5b. Read the comment docs.

@sokomishalov sokomishalov self-assigned this Nov 1, 2020
@mp911de
Copy link
Collaborator

mp911de commented Nov 2, 2020

@sokomishalov do you want to go forward and merge this PR to main and 6.0.x?

FTR, squash commits into a single one and edit the commit message to match the Lettuce commit message format (here are two commits for a PR merge: 5810f96 and b240c58). You can add @author Julien Ruaux in the polishing commit.

@sokomishalov sokomishalov merged commit fe70d44 into redis:main Nov 4, 2020
sokomishalov pushed a commit that referenced this pull request Nov 4, 2020
NestedMultiOutput does not implement CommandOutput.set(double number) which causes problem with RediSearch FT.INFO command
@sokomishalov
Copy link
Collaborator

@mp911de well, looks I did it

@dengliming dengliming linked an issue Nov 5, 2020 that may be closed by this pull request
@mp911de mp911de added this to the 6.0.2 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NestedMultiOutput does not implement set(double)
3 participants