Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestedMultiOutput does not implement set(double) #1484

Closed
jruaux opened this issue Oct 30, 2020 · 4 comments · Fixed by #1486
Closed

NestedMultiOutput does not implement set(double) #1484

jruaux opened this issue Oct 30, 2020 · 4 comments · Fixed by #1486
Labels
type: regression A regression from a previous release
Milestone
6.0.2

Comments

@jruaux
Copy link
Contributor

jruaux commented Oct 30, 2020 •
edited
Loading

Bug Report

Current Behavior

io.lettuce.core.output.NestedMultiOutput does not implement CommandOutput.set(double number)

Environment

  • Lettuce 6.0.0.RELEASE
  • RediSearch v2.0

Possible Solution

PR: #1485
@jruaux jruaux added the type: bug A general bug label Oct 30, 2020
@jruaux jruaux mentioned this issue Oct 30, 2020
Closed
@mp911de
Copy link
Collaborator

mp911de commented Oct 30, 2020

Care to provide a bit context where that is needed?

@jruaux
Copy link
Contributor Author

jruaux commented Oct 30, 2020

RediSearch FT.INFO command returns doubles as part of its array response and it started to break with Lettuce 6.0.0.RELEASE

@mp911de
Copy link
Collaborator

mp911de commented Oct 30, 2020 •
edited
Loading

Thank you.

@mp911de mp911de added type: feature A new feature and removed type: bug A general bug labels Oct 30, 2020
@jruaux jruaux mentioned this issue Oct 31, 2020
Merged
@mp911de mp911de added type: regression A regression from a previous release and removed type: feature A new feature labels Oct 31, 2020
@dengliming dengliming linked a pull request Nov 5, 2020 that will close this issue
Implement set(double) in NestedMultiOutput #1486
Merged
@dengliming
Copy link
Contributor

@jruaux Thanks.

@mp911de mp911de added this to the 6.0.2 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
6.0.2
Development

Successfully merging a pull request may close this issue.

Implement set(double) in NestedMultiOutput
3 participants
@mp911de @jruaux @dengliming