Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement set(double) in NestedMultiOutput #1485

Closed
wants to merge 1 commit into from
Closed

Implement set(double) in NestedMultiOutput #1485

wants to merge 1 commit into from

Conversation

jruaux
Copy link
Contributor

@jruaux jruaux commented Oct 30, 2020

@mp911de
Copy link
Collaborator

mp911de commented Oct 30, 2020

Care to extend the existing test for the output code?

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #1485 into main will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1485   +/-   ##
=========================================
  Coverage     78.83%   78.84%           
+ Complexity     6203     6202    -1     
=========================================
  Files           461      461           
  Lines         20739    20743    +4     
  Branches       2282     2282           
=========================================
+ Hits          16349    16354    +5     
- Misses         3334     3335    +1     
+ Partials       1056     1054    -2     
Impacted Files Coverage Δ Complexity Δ
...java/io/lettuce/core/output/NestedMultiOutput.java 75.75% <0.00%> (-10.45%) 11.00 <0.00> (ø)
.../io/lettuce/core/protocol/ReconnectionHandler.java 78.37% <0.00%> (-5.41%) 20.00% <0.00%> (-2.00%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 87.82% <0.00%> (ø) 1.00% <0.00%> (ø%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 80.39% <0.00%> (+0.65%) 37.00% <0.00%> (-2.00%) ⬆️
...ce/core/masterreplica/SentinelTopologyRefresh.java 85.62% <0.00%> (+0.65%) 35.00% <0.00%> (ø%)
.../java/io/lettuce/core/protocol/CommandHandler.java 75.38% <0.00%> (+1.79%) 113.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73711f7...db97f56. Read the comment docs.

@jruaux jruaux closed this Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants