-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a Coroutine variant of ScanStream/ScanIterator #1438
Conversation
b20c416
to
3d39dc7
Compare
Codecov Report
@@ Coverage Diff @@
## main #1438 +/- ##
============================================
- Coverage 78.82% 78.79% -0.04%
- Complexity 6183 6219 +36
============================================
Files 460 462 +2
Lines 20800 20774 -26
Branches 2302 2295 -7
============================================
- Hits 16396 16369 -27
- Misses 3338 3345 +7
+ Partials 1066 1060 -6
Continue to review full report at Codecov.
|
d1ec2d7
to
fe83f0b
Compare
Moving this into the next iteration. Will review this PR after the release of 6.0. |
fe83f0b
to
cfab8e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two comments, one about the overall design, one about splitting this PR into two commits to keep commits focussed on the actual topic.
src/main/kotlin/io/lettuce/core/api/coroutines/RedisKeyCoroutinesCommandsExtensions.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/io/lettuce/core/api/coroutines/CoroutinesIntegrationTests.kt
Outdated
Show resolved
Hide resolved
bb4238a
to
3b30ade
Compare
3b30ade
to
1220007
Compare
I'm going to take this PR from here. |
We now provide ScanFlow as adapter for ScanStream. Original pull request: #1438.
Update what's new section. Remove JvmOverloads annotation since ScanFlow isn't intended to be used from Java or other JVM languages. Add support and test for zscan. Reduce iterations to 300. Remove superfluous kotlin-stdlib-jdk8 dependency. Add since tag and license header. Original pull request: #1438.
Thank you for your contribution. That's merged and polished now. |
Implements #1435
P.S. Actually I'm not sure about the extension's signature due to the compiler conflict with existing member methods.
It makes end-users provide import aliases (see
ScanStreamCoroutinesIntegrationTests
).Also maybe we should not underly on the
ScanStream
and provide separate and independent one.