Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a Coroutine variant of ScanStream/ScanIterator #1435

Closed
mp911de opened this issue Sep 29, 2020 · 2 comments
Closed

Provide a Coroutine variant of ScanStream/ScanIterator #1435

mp911de opened this issue Sep 29, 2020 · 2 comments
Labels
type: feature A new feature
Milestone
6.1 M1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Sep 29, 2020

We should expose a more user-friendly interface to allow using [H|S|Z]SCAN commands through Coroutines following the design of ScanStream.
@mp911de mp911de added the type: feature A new feature label Sep 29, 2020
@mp911de mp911de mentioned this issue Sep 29, 2020
Closed
@sokomishalov
Copy link
Collaborator

Should it be a breaking replacement for existing "cursor" API or just a bunch of extensions for ...Commands?

@mp911de
Copy link
Collaborator Author

mp911de commented Sep 30, 2020

I think a Kotlin class (or extension) should be fine. Maybe even an extension providing static extension functions accepting e.g. RedisHashSuspendableCommands, RedisKeySuspendableCommands, … returning Flow would be fine, too.

@sokomishalov sokomishalov mentioned this issue Oct 1, 2020
Closed
sokomishalov added a commit to sokomishalov/lettuce that referenced this issue Nov 1, 2020
@sokomishalov
ScanStream bridge to the coroutines API redis#1435
1220007
mp911de pushed a commit that referenced this issue Nov 2, 2020
@sokomishalov @mp911de
Add ScanFlow to enable Coroutines usage of SCAN #1435
9297d0c 
We now provide ScanFlow as adapter for ScanStream.

Original pull request: #1438.
mp911de added a commit that referenced this issue Nov 2, 2020
@mp911de
Polishing #1435
feea1e6 
Update what's new section. Remove JvmOverloads annotation since ScanFlow isn't intended to be used from Java or other JVM languages. Add support and test for zscan. Reduce iterations to 300. Remove superfluous kotlin-stdlib-jdk8 dependency.

Add since tag and license header.

Original pull request: #1438.
@mp911de mp911de added this to the 6.1 M1 milestone Nov 2, 2020
@mp911de mp911de closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.1 M1
Development

No branches or pull requests
2 participants
@mp911de @sokomishalov