Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug logging of ConnectionWatchdog has wrong prefix after reconnect. #645

Closed
mlex opened this issue Nov 9, 2017 · 3 comments
Closed

Debug logging of ConnectionWatchdog has wrong prefix after reconnect. #645

mlex opened this issue Nov 9, 2017 · 3 comments
Labels
type: bug A general bug
Milestone

Comments

@mlex
Copy link

mlex commented Nov 9, 2017

All ConnectionWatchdog debug logs are prefixed with a channel descriptor. This prefix is stored in the logPrefix field.

After a reconnect, the logPrefix is not updated, which leads to rather confusing log messages, because the channel descriptor in the log message does not represent the actually active channel.

For example in the following log message the current channel is actually /10.255.101.203:41124 -> /10.255.94.48:6381 while the log prefix shows /10.255.101.203:33545 -> /10.255.94.48:6381:

2017-11-09 10:12:40,958 [lettuce-nioEventLoop-5-15] DEBUG c.l.r.protocol.ConnectionWatchdog - [channel=0xeb2bc9b7, /10.255.101.203:33545 -> /10.255.94.48:6381, last known addr=/10.255.94.48:6381] channelInactive(ChannelHandlerContext(ConnectionWatchdog#0, [id: 0x8982a021, L:/10.255.101.203:41124 ! R:/10.255.94.48:6381]))

We found this bug in version 3.4.2.Final, but it is probably still relevant for latest SNAPSHOT.

@mp911de mp911de added the type: bug A general bug label Nov 9, 2017
@mp911de
Copy link
Collaborator

mp911de commented Nov 9, 2017

Thanks for the bug report. Please note that Lettuce 3.x isn't maintained anymore. Please upgrade to Lettuce 4 or 5.

@mlex
Copy link
Author

mlex commented Nov 9, 2017

Sorry, I meant 4.4.0.Final. My fault.

@mp911de
Copy link
Collaborator

mp911de commented Nov 12, 2017

That's fixed now.

@mp911de mp911de closed this as completed Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants