Reset ConnectionWatchdog log-prefix after connect #645

redis · Nov 12, 2017 · ef21b53 · ef21b53
1 parent 47acf91
commit ef21b53
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/main/java/com/lambdaworks/redis/protocol/CommandHandler.java b/src/main/java/com/lambdaworks/redis/protocol/CommandHandler.java
@@ -1150,10 +1150,9 @@ protected String logPrefix() {
             return logPrefix;
         }
 
-        StringBuffer buffer = new StringBuffer(64);
-        buffer.append('[').append(ChannelLogDescriptor.logDescriptor(channel)).append(", ").append("chid=0x")
-                .append(Long.toHexString(commandHandlerId)).append(']');
-        return logPrefix = buffer.toString();
+        String buffer = "[" + ChannelLogDescriptor.logDescriptor(channel) + ", " + "chid=0x"
+                + Long.toHexString(commandHandlerId) + ']';
+        return logPrefix = buffer;
     }
 
     protected static <T> List<T> drainCommands(Queue<T> source) {

diff --git a/src/main/java/com/lambdaworks/redis/protocol/ConnectionWatchdog.java b/src/main/java/com/lambdaworks/redis/protocol/ConnectionWatchdog.java
@@ -162,6 +162,7 @@ public void channelActive(ChannelHandlerContext ctx) throws Exception {
         }
 
         reconnectScheduleTimeout = null;
+        logPrefix = null;
         channel = ctx.channel();
         remoteAddress = channel.remoteAddress();
         logger.debug("{} channelActive({})", logPrefix(), ctx);
@@ -348,9 +349,7 @@ private String logPrefix() {
             return logPrefix;
         }
 
-        StringBuilder buffer = new StringBuilder(64);
-        buffer.append('[')
-                .append(ChannelLogDescriptor.logDescriptor(channel)).append(", last known addr=").append(remoteAddress).append(']');
-        return logPrefix = buffer.toString();
+        String buffer = "[" + ChannelLogDescriptor.logDescriptor(channel) + ", last known addr=" + remoteAddress + ']';
+        return logPrefix = buffer;
     }
 }