-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider reinstating master-replica wording #1518
Labels
type: feature
A new feature
Milestone
Comments
mp911de
added a commit
that referenced
this issue
Jan 22, 2021
After community feedback, we're getting back to Master/Replica from Upstream/Replica to not introduce confusion with the term Upstream.
mp911de
added a commit
that referenced
this issue
Jan 22, 2021
After community feedback, we're getting back to Master/Replica from Upstream/Replica to not introduce confusion with the term Upstream.
That's in place now, also in 6.0.x. |
Greatly appreciated @mp911de, thanks for listening. 🙇 |
This was referenced Mar 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(Follow-up to #1308 (comment))
Very late to the party, but I happened to see the
UPSTREAM
-terminology being used now while looking at the Lettuce Wiki for Lettuce 6. I'm not so sure this deprecation fully makes sense @mp911de. Lettuce is a Redis driver and AFAIK, Redis uses the "master-replication" terminology, as in https://redis.io/topics/replication. Note how that page quite elegantly avoids using the word "slave", which I think is the more potentially offensive language."Upstream", AFAIK, is not a word that is being actively used in Redis terminology (please correct me if I'm wrong!), so us using it feels like it does more harm than good.
Some more reading on the subject:
TL;DR: As far as I understand it, Redis uses the "master-replication" terminology. I think we are doing ourselves and the community harm if we deviate from this terminology, it just confusing. If you think this terminology is wrong/bad, I think we should try to get Redis to stop using it as well.
I personally find "master-replica" a good compromise between the "very progressive" and "very traditionalist" viewpoints. It's a balance to be had, and I think @antirez did a good job in redis/redis#5335.
The text was updated successfully, but these errors were encountered: