Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reinstating master-replica wording #1518

Closed
perlun opened this issue Nov 13, 2020 · 2 comments
Closed

Consider reinstating master-replica wording #1518

perlun opened this issue Nov 13, 2020 · 2 comments
Labels
type: feature A new feature
Milestone

Comments

@perlun
Copy link
Contributor

perlun commented Nov 13, 2020

(Follow-up to #1308 (comment))

Very late to the party, but I happened to see the UPSTREAM-terminology being used now while looking at the Lettuce Wiki for Lettuce 6. I'm not so sure this deprecation fully makes sense @mp911de. Lettuce is a Redis driver and AFAIK, Redis uses the "master-replication" terminology, as in https://redis.io/topics/replication. Note how that page quite elegantly avoids using the word "slave", which I think is the more potentially offensive language.

"Upstream", AFAIK, is not a word that is being actively used in Redis terminology (please correct me if I'm wrong!), so us using it feels like it does more harm than good.

Some more reading on the subject:


TL;DR: As far as I understand it, Redis uses the "master-replication" terminology. I think we are doing ourselves and the community harm if we deviate from this terminology, it just confusing. If you think this terminology is wrong/bad, I think we should try to get Redis to stop using it as well.

I personally find "master-replica" a good compromise between the "very progressive" and "very traditionalist" viewpoints. It's a balance to be had, and I think @antirez did a good job in redis/redis#5335.

@perlun perlun added the type: feature A new feature label Nov 13, 2020
@mp911de mp911de added this to the 6.0.3 milestone Jan 22, 2021
mp911de added a commit that referenced this issue Jan 22, 2021
After community feedback, we're getting back to Master/Replica from Upstream/Replica to not introduce confusion with the term Upstream.
mp911de added a commit that referenced this issue Jan 22, 2021
After community feedback, we're getting back to Master/Replica from Upstream/Replica to not introduce confusion with the term Upstream.
@mp911de
Copy link
Collaborator

mp911de commented Jan 22, 2021

That's in place now, also in 6.0.x.

@mp911de mp911de closed this as completed Jan 22, 2021
mp911de added a commit that referenced this issue Jan 22, 2021
@perlun
Copy link
Contributor Author

perlun commented Jan 22, 2021

That's in place now, also in 6.0.x.

Greatly appreciated @mp911de, thanks for listening. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants